[GitHub] [beam] lukecwik commented on a change in pull request #11911: [BEAM-10186] Send an error to the runner for certain split and progress failures

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #11911:
URL: https://github.com/apache/beam/pull/11911#discussion_r442563624



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/BeamFnControlClient.java
##########
@@ -159,6 +159,16 @@ public void processInstructionRequests(Executor executor)
             } catch (Error e) {
               sendErrorResponse(e);
               throw e;
+            } catch (IllegalStateException e) {

Review comment:
       Instead of adding this try catch, we should up date the handler to not throw the exception in the first place.
   Here: https://github.com/apache/beam/blob/bca893e86a04f7245df1476597f157b3b6fa0651/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java#L378
   Here: https://github.com/apache/beam/blob/bca893e86a04f7245df1476597f157b3b6fa0651/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java#L344
   
   We should add a simple unit test that covers this as well.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org