You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Phillip Webb (JIRA)" <ji...@apache.org> on 2009/07/07 18:40:14 UTC
[jira] Created: (IVYDE-188) Workspace Resolver Prevents Source
Download
Workspace Resolver Prevents Source Download
-------------------------------------------
Key: IVYDE-188
URL: https://issues.apache.org/jira/browse/IVYDE-188
Project: IvyDE
Issue Type: Bug
Components: workspace resolver
Affects Versions: 2.0.0.beta1
Environment: Ivy 2.0
Reporter: Phillip Webb
Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:
ivy.getResolveEngine.download(....)
This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.
The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVYDE-188) Workspace Resolver Prevents Source
Download
Posted by "Phillip Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillip Webb updated IVYDE-188:
-------------------------------
Attachment: (was: IVYDE-188.patch)
> Workspace Resolver Prevents Source Download
> -------------------------------------------
>
> Key: IVYDE-188
> URL: https://issues.apache.org/jira/browse/IVYDE-188
> Project: IvyDE
> Issue Type: Bug
> Components: workspace resolver
> Affects Versions: 2.0.0.beta1
> Environment: Ivy 2.0
> Reporter: Phillip Webb
>
> Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:
> ivy.getResolveEngine.download(....)
> This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.
> The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-188) Workspace Resolver Prevents Source
Download
Posted by "Phillip Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728274#action_12728274 ]
Phillip Webb commented on IVYDE-188:
------------------------------------
Using DownloadStatus.FAILED seems to fix the problem
> Workspace Resolver Prevents Source Download
> -------------------------------------------
>
> Key: IVYDE-188
> URL: https://issues.apache.org/jira/browse/IVYDE-188
> Project: IvyDE
> Issue Type: Bug
> Components: workspace resolver
> Affects Versions: 2.0.0.beta1
> Environment: Ivy 2.0
> Reporter: Phillip Webb
> Attachments: IVYDE-188.patch
>
>
> Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:
> ivy.getResolveEngine.download(....)
> This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.
> The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVYDE-188) Workspace Resolver Prevents Source
Download
Posted by "Phillip Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillip Webb updated IVYDE-188:
-------------------------------
Attachment: IVYDE-188.patch
Attached Patch
> Workspace Resolver Prevents Source Download
> -------------------------------------------
>
> Key: IVYDE-188
> URL: https://issues.apache.org/jira/browse/IVYDE-188
> Project: IvyDE
> Issue Type: Bug
> Components: workspace resolver
> Affects Versions: 2.0.0.beta1
> Environment: Ivy 2.0
> Reporter: Phillip Webb
> Attachments: IVYDE-188.patch
>
>
> Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:
> ivy.getResolveEngine.download(....)
> This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.
> The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVYDE-188) Workspace Resolver Prevents Source
Download
Posted by "Phillip Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phillip Webb updated IVYDE-188:
-------------------------------
Attachment: IVYDE-188.patch
Attached a patch
> Workspace Resolver Prevents Source Download
> -------------------------------------------
>
> Key: IVYDE-188
> URL: https://issues.apache.org/jira/browse/IVYDE-188
> Project: IvyDE
> Issue Type: Bug
> Components: workspace resolver
> Affects Versions: 2.0.0.beta1
> Environment: Ivy 2.0
> Reporter: Phillip Webb
> Attachments: IVYDE-188.patch
>
>
> Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:
> ivy.getResolveEngine.download(....)
> This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.
> The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVYDE-188) Workspace Resolver Prevents Source
Download
Posted by "Nicolas Lalevée (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Lalevée resolved IVYDE-188.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.1.0
Assignee: Nicolas Lalevée
DownloadStatus.FAILED resolve the issue yes, thanks.
But then it raised another one: the module descriptor of a project was declaring a default jar artifact which will then failed to be download (intead of no download).
Both are now fixed in trunk.
> Workspace Resolver Prevents Source Download
> -------------------------------------------
>
> Key: IVYDE-188
> URL: https://issues.apache.org/jira/browse/IVYDE-188
> Project: IvyDE
> Issue Type: Bug
> Components: workspace resolver
> Affects Versions: 2.0.0.beta1
> Environment: Ivy 2.0
> Reporter: Phillip Webb
> Assignee: Nicolas Lalevée
> Fix For: 2.1.0
>
> Attachments: IVYDE-188.patch
>
>
> Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:
> ivy.getResolveEngine.download(....)
> This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.
> The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-188) Workspace Resolver Prevents Source
Download
Posted by "Phillip Webb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVYDE-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728249#action_12728249 ]
Phillip Webb commented on IVYDE-188:
------------------------------------
Removed the patch, the resolver cannot skip adding a download report.
> Workspace Resolver Prevents Source Download
> -------------------------------------------
>
> Key: IVYDE-188
> URL: https://issues.apache.org/jira/browse/IVYDE-188
> Project: IvyDE
> Issue Type: Bug
> Components: workspace resolver
> Affects Versions: 2.0.0.beta1
> Environment: Ivy 2.0
> Reporter: Phillip Webb
>
> Source attachments triggered in the second half of the IvyResolveJob.getSourceArtifactPath method call the ivy resolve engine:
> ivy.getResolveEngine.download(....)
> This in turn delegates to a ChainResolver. The chain resolver stops at the first item in the chain to return a download report.
> The WorkspaceResolver currently returns a download report for non workspace project with DownloadStatus.NO, I think it should probably just skip adding the report so the chain can continue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.