[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5648: IPv6: fix deploy vm issue in ipv6-only networks without VR

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5648:
URL: https://github.com/apache/cloudstack/pull/5648#discussion_r741107965



##########
File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
##########
@@ -195,13 +195,23 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
      * address information.
      */
     @Override
-    public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
+    public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) throws InsufficientAddressCapacityException {
         if (network.getIp6Gateway() != null) {
             if (nic.getIPv6Address() == null) {
                 s_logger.debug("Found IPv6 CIDR " + network.getIp6Cidr() + " for Network " + network);
                 nic.setIPv6Cidr(network.getIp6Cidr());
                 nic.setIPv6Gateway(network.getIp6Gateway());
 
+                if (nic.getBroadcastType() == null) {
+                    nic.setBroadcastType(network.getBroadcastDomainType());
+                }
+                if (nic.getBroadCastUri() == null) {
+                    nic.setBroadcastUri(network.getBroadcastUri());
+                }
+                if (nic.getMacAddress() == null) {
+                    nic.setMacAddress(_networkModel.getNextAvailableMacAddressInNetwork(network.getId()));
+                }
+

Review comment:
       done. thanks @sureshanaparti @DaanHoogland @GabrielBrascher for review.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org