[GitHub] [pulsar] AnonHxy commented on a diff in pull request #19355: [fix] [ml] messagesConsumedCounter of NonDurableCursor was initialized incorrectly

["AnonHxy (via GitHub)" <gi...@apache.org>]

AnonHxy commented on code in PR #19355:
URL: https://github.com/apache/pulsar/pull/19355#discussion_r1090217433


##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorTest.java:
##########
@@ -824,5 +824,16 @@ void deleteNonDurableCursorWithName() throws Exception {
         assertEquals(Iterables.size(ledger.getCursors()), 0);
     }
 
+    @Test
+    public void testMessagesConsumedCounterInitializedCorrect() throws Exception {
+        ManagedLedger ledger = factory.open("testMessagesConsumedCounterInitializedCorrect",

Review Comment:
   `ledger` should be closed finaly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org