You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Szabolcs Vasas <va...@gmail.com> on 2016/05/20 22:16:14 UTC

Review Request 47674: Sqoop2: Support using password generators for repository passwords

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47674/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2914
    https://issues.apache.org/jira/browse/SQOOP-2914


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Support using password generators for repository passwords


Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 0a8139a 
  core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java 12cb93e 

Diff: https://reviews.apache.org/r/47674/diff/


Testing
-------


Thanks,

Szabolcs Vasas

Re: Review Request 47674: Sqoop2: Support using password generators for repository passwords

Posted by Boglarka Egyed <eg...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47674/#review134485
-----------------------------------------------------------


Ship it!




Ship It!

- Boglarka Egyed


On May 20, 2016, 10:17 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47674/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 10:17 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2914
>     https://issues.apache.org/jira/browse/SQOOP-2914
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Support using password generators for repository passwords
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 0a8139a 
>   core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java 12cb93e 
> 
> Diff: https://reviews.apache.org/r/47674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 47674: Sqoop2: Support using password generators for repository passwords

Posted by Abraham Fine <ab...@abrahamfine.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47674/#review134510
-----------------------------------------------------------




common-test/src/main/java/org/apache/sqoop/common/test/repository/DerbyRepositoryProvider.java (line 41)
<https://reviews.apache.org/r/47674/#comment199378>

    i am not convinced that this line of code is actually testing anything. I believe these properties configure the "sqoop.properties file" for the JettySqoopMiniCluster. 
    
    So here I think we are configuring sqoop to log into the repository with a password but the repository is never configured to require one. 
    
    I found this guide on setting up passwords for embedded derby instances: https://db.apache.org/derby/docs/10.0/manuals/develop/develop120.html
    
    It looks like we may need to add another initialization method th RepositoryProviderBase that the DerbyRepositoryProvider uses to set the password.


- Abraham Fine


On May 24, 2016, 1:28 a.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47674/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 1:28 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2914
>     https://issues.apache.org/jira/browse/SQOOP-2914
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Support using password generators for repository passwords
> 
> 
> Diffs
> -----
> 
>   common-test/src/main/java/org/apache/sqoop/common/test/repository/DerbyRepositoryProvider.java 6c75786 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 0a8139a 
>   core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java 12cb93e 
> 
> Diff: https://reviews.apache.org/r/47674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 47674: Sqoop2: Support using password generators for repository passwords

Posted by Abraham Fine <ab...@abrahamfine.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47674/#review134627
-----------------------------------------------------------



really appreciate all of the additional tests, 2 more small comments and then the code should be ready to commit.


core/src/test/java/org/apache/sqoop/repository/TestJdbcRepositoryContextInitialization.java (line 41)
<https://reviews.apache.org/r/47674/#comment199465>

    this can likely be put in a "before" method so it does not need to be repeated.



core/src/test/java/org/apache/sqoop/repository/TestJdbcRepositoryContextInitialization.java (line 49)
<https://reviews.apache.org/r/47674/#comment199466>

    nit-pick: test names are a little long, could rename to "testInvalidJdbcHandlerClassName"


- Abraham Fine


On May 24, 2016, 8:16 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47674/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 8:16 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2914
>     https://issues.apache.org/jira/browse/SQOOP-2914
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Support using password generators for repository passwords
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 0a8139a 
>   core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java 12cb93e 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepositoryContextInitialization.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 47674: Sqoop2: Support using password generators for repository passwords

Posted by Boglarka Egyed <eg...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47674/#review134639
-----------------------------------------------------------


Ship it!




Ship It!

- Boglarka Egyed


On May 24, 2016, 8:56 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47674/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 8:56 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2914
>     https://issues.apache.org/jira/browse/SQOOP-2914
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Support using password generators for repository passwords
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryContext.java 0a8139a 
>   core/src/main/java/org/apache/sqoop/repository/RepoConfigurationConstants.java 12cb93e 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepositoryContext.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>