You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/17 21:12:21 UTC

[GitHub] [lucene-solr] gsmiller opened a new pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

gsmiller opened a new pull request #2577:
URL: https://github.com/apache/lucene-solr/pull/2577


   Backport from `main`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] gsmiller closed pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

Posted by GitBox <gi...@apache.org>.
gsmiller closed pull request #2577:
URL: https://github.com/apache/lucene-solr/pull/2577


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] gsmiller commented on pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #2577:
URL: https://github.com/apache/lucene-solr/pull/2577#issuecomment-922085560


   @goankur could you please take a quick look and make sure this backport looks good to you? Everything was very trivial except for `LongValueFacetCounts`. Even that was pretty easy but there are some non-back-compat changes on `main` that required me to do some manual editing (so a double-check on that class in particular would be appreciated).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] goankur commented on pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

Posted by GitBox <gi...@apache.org>.
goankur commented on pull request #2577:
URL: https://github.com/apache/lucene-solr/pull/2577#issuecomment-923124877


   @gsmiller I did take a look at `LongValueFacetCounts` and other changes and everything looks good to me. Thanks for taking care of back porting this to `8_x` branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] gsmiller commented on pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #2577:
URL: https://github.com/apache/lucene-solr/pull/2577#issuecomment-922123533


   FYI, will hold on this backport until 8.10 releases and an 8.11 section is added to CHANGES as part of that process (this will go in 8.11)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] gsmiller closed pull request #2577: LUCENE-10070: Skip deleted documents during facet counting for all documents

Posted by GitBox <gi...@apache.org>.
gsmiller closed pull request #2577:
URL: https://github.com/apache/lucene-solr/pull/2577


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org