You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2026/03/04 19:52:13 UTC
[I] rust: Remove no_run from Rust examples [sedona-db]
paleolimbot opened a new issue, #688:
URL: https://github.com/apache/sedona-db/issues/688
In general our Rust API has very light examples. We have some of them that are marked `ignore` or `no_run`, which means they can go stale/present non-working code without being caught by `cargo test`. LLMs love to add examples with these markers but we should strive to not have any...it is probably better to remove examples rather than keep examples that may not work. As we learn which APIs are used externally and which ones are targeted only for other sedona- crates we can prioritize additional Rust examples that show up in the rust documentation.
This may be a good opportunity to check our Rust docs more thoroughly (DataFusion has some CI jobs for this that check typos, formatting, and linking).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Remove no_run from Rust examples [sedona-db]
Posted by "Mayankaggarwal8055 (via GitHub)" <gi...@apache.org>.
Mayankaggarwal8055 commented on issue #688:
URL: https://github.com/apache/sedona-db/issues/688#issuecomment-4060691144
Hi @paleolimbot 👋
I'd like to work on this issue.
**Progress:**
- Found `rust,norun` markers in `rust/sedona/src/context_builder.rs` (2x)
- Found `rust,norun` + `rust,ignore` in `rust/sedona-geometry/src/transform.rs`
- Fixed all markers → examples now run as doctests
- Verified: `cd rust/sedona-geometry && cargo test --doc` passes ✅
- Full repo audit: `Select-String "rust,norun|rust,ignore"` → 0 hits ✅
Pushing PR shortly. Thanks for the clear issue! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Remove no_run from Rust examples [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #688:
URL: https://github.com/apache/sedona-db/issues/688#issuecomment-4060651905
Sounds good! I'm in general not fussed about the examples because our public Rust API isn't really well defined but it would be great to keep the ones that we do have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Remove no_run from Rust examples [sedona-db]
Posted by "Mayankaggarwal8055 (via GitHub)" <gi...@apache.org>.
Mayankaggarwal8055 commented on issue #688:
URL: https://github.com/apache/sedona-db/issues/688#issuecomment-4060601736
Hi, I’d like to work on this issue. I’ll audit the Rust doc examples marked no_run or ignore, see which can be made runnable, and propose removing or updating the ones that can go stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] rust: Remove no_run from Rust examples [sedona-db]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed issue #688: rust: Remove no_run from Rust examples
URL: https://github.com/apache/sedona-db/issues/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org