You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/07 22:32:20 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #9767: [docs] Add SSL config options for postgres
nytai opened a new pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [x] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add some SSL documentation to PG docs
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@craig-rueda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.90%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.91%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10158 +4971
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `93.54% <0.00%> (ø)` | |
| [superset-frontend/src/welcome/Welcome.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvV2VsY29tZS5qc3g=) | `78.57% <0.00%> (ø)` | |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `29.41% <0.00%> (ø)` | |
| [...frontend/src/components/BootstrapSliderWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.85% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (ø)` | |
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `27.77% <0.00%> (ø)` | |
| [...perset-frontend/src/components/FilterBadgeIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyQmFkZ2VJY29uLmpzeA==) | `50.00% <0.00%> (ø)` | |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlck9wdGlvbi5qc3g=) | `57.69% <0.00%> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...93e754e](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.85% -0.08%
==========================================
Files 183 183
Lines 17847 17851 +4
==========================================
- Hits 12660 12649 -11
- Misses 5187 5202 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `70.85% <ø> (-0.08%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-1.62%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.91%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.92%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10160 +4973
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (ø)` | |
| [...tend/src/dashboard/containers/FilterIndicators.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlckluZGljYXRvcnMuanN4) | `77.77% <0.00%> (ø)` | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `89.01% <0.00%> (ø)` | |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `22.58% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | `100.00% <0.00%> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `71.87% <0.00%> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/profile/components/Favorites.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMuanN4) | `86.66% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `0.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.80% -0.14%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 21555 +8895
- Misses 5187 8774 +3587
- Partials 0 115 +115
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.69% <ø> (?)` | |
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/explore/components/AdhocMetricStaticOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1N0YXRpY09wdGlvbi5qc3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...end/src/visualizations/TimeTable/SparklineCell.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9TcGFya2xpbmVDZWxsLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getLocationHash.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExvY2F0aW9uSGFzaC5qcw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | `100.00% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | `100.00% <0.00%> (ø)` | |
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <0.00%> (ø)` | |
| [...hboard/components/gridComponents/new/NewHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdIZWFkZXIuanN4) | `100.00% <0.00%> (ø)` | |
| [...erset-frontend/src/profile/components/UserInfo.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9Vc2VySW5mby5qc3g=) | `100.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.56% -0.38%
==========================================
Files 183 587 +404
Lines 17847 30460 +12613
Branches 0 3121 +3121
==========================================
+ Hits 12660 21494 +8834
- Misses 5187 8845 +3658
- Partials 0 121 +121
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.91% <ø> (?)` | |
| #javascript | `59.00% <ø> (?)` | |
| #python | `70.92% <ø> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.13% <0.00%> (-0.73%)` | :arrow_down: |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | `0.00% <0.00%> (ø)` | |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `67.44% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (ø)` | |
| [superset-frontend/src/logger/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4Lmpz) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/Histogram.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IaXN0b2dyYW0uanM=) | `0.00% <0.00%> (ø)` | |
| [...hboard/components/menu/BackgroundStyleDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvQmFja2dyb3VuZFN0eWxlRHJvcGRvd24uanN4) | `100.00% <0.00%> (ø)` | |
| [...dashboard/components/menu/MarkdownModeDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvTWFya2Rvd25Nb2RlRHJvcGRvd24uanN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/TableLoader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVMb2FkZXIuanN4) | `6.66% <0.00%> (ø)` | |
| ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `5.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.89% -5.04%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20061 +7401
- Misses 5187 10197 +5010
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (ø)` | |
| [...d/util/logging/getLoadStatsPerTopLevelComponent.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZ2V0TG9hZFN0YXRzUGVyVG9wTGV2ZWxDb21wb25lbnQuanM=) | `0.00% <0.00%> (ø)` | |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.91%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.92%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10160 +4973
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/explore/controlPanels/Markup.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXJrdXAuanM=) | `0.00% <0.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Table.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UYWJsZS5qc3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/errorMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Vycm9yTWVzc2FnZXMuanM=) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/explore/controlPanels/DeckArc.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrQXJjLmpz) | `0.00% <0.00%> (ø)` | |
| [...shboard/components/filterscope/FilterFieldTree.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkVHJlZS5qc3g=) | `44.44% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | `80.88% <0.00%> (ø)` | |
| [...hboard/components/menu/BackgroundStyleDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvQmFja2dyb3VuZFN0eWxlRHJvcGRvd24uanN4) | `100.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `92.00% <0.00%> (ø)` | |
| [...d/util/logging/getLoadStatsPerTopLevelComponent.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZ2V0TG9hZFN0YXRzUGVyVG9wTGV2ZWxDb21wb25lbnQuanM=) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `82.53% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.80% -0.14%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 21555 +8895
- Misses 5187 8774 +3587
- Partials 0 115 +115
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.69% <ø> (?)` | |
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `100.00% <0.00%> (ø)` | |
| [...tend/src/dashboard/containers/FilterIndicators.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlckluZGljYXRvcnMuanN4) | `100.00% <0.00%> (ø)` | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `89.01% <0.00%> (ø)` | |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `22.58% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | `100.00% <0.00%> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `78.12% <0.00%> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/profile/components/Favorites.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMuanN4) | `86.66% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.94%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.99% -4.95%
==========================================
Files 183 587 +404
Lines 17847 30460 +12613
Branches 0 3121 +3121
==========================================
+ Hits 12660 20101 +7441
- Misses 5187 10175 +4988
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.00% <ø> (?)` | |
| #python | `70.92% <ø> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.13% <0.00%> (-0.73%)` | :arrow_down: |
| [...src/explore/components/controls/SpatialControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TcGF0aWFsQ29udHJvbC5qc3g=) | `6.66% <0.00%> (ø)` | |
| [...perset-frontend/src/dashboard/util/findParentId.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRQYXJlbnRJZC5qcw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/visualizations/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL2NvbnN0YW50cy5qcw==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `78.35% <0.00%> (ø)` | |
| [...d/src/visualizations/TimeTable/FormattedNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9Gb3JtYXR0ZWROdW1iZXIuanN4) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.50% <0.00%> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `82.14% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `100.00% <0.00%> (ø)` | |
| ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `17.28%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
===========================================
- Coverage 70.93% 53.65% -17.29%
===========================================
Files 183 352 +169
Lines 17847 11243 -6604
Branches 0 2785 +2785
===========================================
- Hits 12660 6032 -6628
+ Misses 5187 5031 -156
- Partials 0 180 +180
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (?)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | | |
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | | |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | | |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
| [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | | |
| ... and [525 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...93e754e](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.94%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.99% -4.95%
==========================================
Files 183 587 +404
Lines 17847 30460 +12613
Branches 0 3121 +3121
==========================================
+ Hits 12660 20101 +7441
- Misses 5187 10175 +4988
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.00% <ø> (?)` | |
| #python | `70.92% <ø> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.13% <0.00%> (-0.73%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEdyaWQuanN4) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `92.63% <0.00%> (ø)` | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQuanN4) | `100.00% <0.00%> (ø)` | |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `29.16% <0.00%> (ø)` | |
| [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `80.28% <0.00%> (ø)` | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | `100.00% <0.00%> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <0.00%> (ø)` | |
| ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.71% -0.22%
==========================================
Files 183 183
Lines 17847 17847
==========================================
- Hits 12660 12621 -39
- Misses 5187 5226 +39
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...93e754e](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.90%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.91%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10158 +4971
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/LimitControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC5qc3g=) | `87.17% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/explore/controlPanels/Shared\_Global.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfR2xvYmFsLmpz) | `0.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/Histogram.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IaXN0b2dyYW0uanM=) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/dashboard/util/componentIsResizable.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLmpz) | `100.00% <0.00%> (ø)` | |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `100.00% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `95.09% <0.00%> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.91%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.92%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20099 +7439
- Misses 5187 10159 +4972
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [...set-frontend/src/explore/components/ControlRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUm93LmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `76.78% <0.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS5qc3g=) | `83.33% <0.00%> (ø)` | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy5qc3g=) | `55.55% <0.00%> (ø)` | |
| [...ontend/src/dashboard/util/getDashboardFilterKey.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS5qcw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `72.72% <0.00%> (ø)` | |
| ... and [394 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.70% -0.23%
==========================================
Files 183 183
Lines 17847 17851 +4
==========================================
- Hits 12660 12622 -38
- Misses 5187 5229 +42
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `70.70% <ø> (-0.23%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.77% <0.00%> (-3.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.80% -0.14%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 21555 +8895
- Misses 5187 8775 +3588
- Partials 0 114 +114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (?)` | |
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `100.00% <0.00%> (ø)` | |
| [...tend/src/dashboard/containers/FilterIndicators.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlckluZGljYXRvcnMuanN4) | `100.00% <0.00%> (ø)` | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `89.01% <0.00%> (ø)` | |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `22.58% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | `100.00% <0.00%> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `78.12% <0.00%> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/profile/components/Favorites.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMuanN4) | `86.66% <0.00%> (ø)` | |
| [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.81% -0.12%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 21558 +8898
- Misses 5187 8770 +3583
- Partials 0 114 +114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.73% <ø> (?)` | |
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS5qc3g=) | `50.00% <0.00%> (ø)` | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `51.65% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `77.41% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/Histogram.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IaXN0b2dyYW0uanM=) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/visualizations/TimeTable/TimeTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGUuanN4) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC5qc3g=) | `87.17% <0.00%> (ø)` | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0NvbXBvbmVudEZhY3RvcnkuanM=) | `100.00% <0.00%> (ø)` | |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <0.00%> (ø)` | |
| [...dashboard/components/FilterIndicatorsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvcnNDb250YWluZXIuanN4) | `82.25% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...609e7d1](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.90%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.91%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10158 +4971
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/util/buildFilterScopeTreeEntry.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2J1aWxkRmlsdGVyU2NvcGVUcmVlRW50cnkuanM=) | `0.00% <0.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.85% <0.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `76.78% <0.00%> (ø)` | |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `62.35% <0.00%> (ø)` | |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `75.32% <0.00%> (ø)` | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `34.84% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.71% -0.22%
==========================================
Files 183 183
Lines 17847 17847
==========================================
- Hits 12660 12621 -39
- Misses 5187 5226 +39
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.80% -0.14%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 21555 +8895
- Misses 5187 8775 +3588
- Partials 0 114 +114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (?)` | |
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT25QYXN0ZVNlbGVjdC5qc3g=) | `95.45% <0.00%> (ø)` | |
| [...hboard/components/gridComponents/new/NewColumn.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdDb2x1bW4uanN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/messageToasts/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29uc3RhbnRzLmpz) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `33.33% <0.00%> (ø)` | |
| [...t-frontend/src/SqlLab/components/TabStatusIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYlN0YXR1c0ljb24uanN4) | `85.71% <0.00%> (ø)` | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC5qcw==) | `90.90% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `81.81% <0.00%> (ø)` | |
| [...rset-frontend/src/dashboard/util/componentTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudFR5cGVzLmpz) | `100.00% <0.00%> (ø)` | |
| [...perset-frontend/src/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `96.77% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.80% -0.14%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 21555 +8895
- Misses 5187 8775 +3588
- Partials 0 114 +114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (?)` | |
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/dashboard/util/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/dashboard/util/componentIsResizable.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLmpz) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `83.11% <0.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.50% <0.00%> (ø)` | |
| [...d/src/visualizations/TimeTable/FormattedNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9Gb3JtYXR0ZWROdW1iZXIuanN4) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `81.81% <0.00%> (ø)` | |
| [...erset-frontend/src/explore/controlPanels/Mapbox.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9NYXBib3guanM=) | `0.00% <0.00%> (ø)` | |
| [...nd/src/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=) | `65.51% <0.00%> (ø)` | |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `76.69% <0.00%> (ø)` | |
| [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | `93.33% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.58% -0.35%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 21489 +8829
- Misses 5187 8832 +3645
- Partials 0 121 +121
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.82% <ø> (?)` | |
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `44.44% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <0.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `93.70% <0.00%> (ø)` | |
| [...plore/components/controls/FixedOrMetricControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaXhlZE9yTWV0cmljQ29udHJvbC5qc3g=) | `51.78% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/ActionMenuItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWN0aW9uTWVudUl0ZW0uanN4) | `0.00% <0.00%> (ø)` | |
| [...rc/dashboard/components/FilterIndicatorTooltip.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvclRvb2x0aXAuanN4) | `100.00% <0.00%> (ø)` | |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `87.50% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (ø)` | |
| [superset-frontend/src/welcome/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvaW5kZXguanN4) | `0.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=) | `95.23% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `5.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.89% -5.04%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20061 +7401
- Misses 5187 10197 +5010
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `93.54% <0.00%> (ø)` | |
| [superset-frontend/src/welcome/Welcome.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvV2VsY29tZS5qc3g=) | `78.57% <0.00%> (ø)` | |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `17.27%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
===========================================
- Coverage 70.93% 53.66% -17.28%
===========================================
Files 183 352 +169
Lines 17847 11243 -6604
Branches 0 2785 +2785
===========================================
- Hits 12660 6033 -6627
+ Misses 5187 5030 -157
- Partials 0 180 +180
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.66% <ø> (?)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | | |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | | |
| [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | | |
| [superset/examples/multi\_line.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | | |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | | |
| ... and [525 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625530592
😠 `fossa`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `5.03%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.89% -5.04%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20061 +7401
- Misses 5187 10197 +5010
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `19.04% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...93e754e](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.81% -0.13%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 21557 +8897
- Misses 5187 8771 +3584
- Partials 0 114 +114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (?)` | |
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | `44.44% <0.00%> (ø)` | |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `100.00% <0.00%> (ø)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `93.70% <0.00%> (ø)` | |
| [...plore/components/controls/FixedOrMetricControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaXhlZE9yTWV0cmljQ29udHJvbC5qc3g=) | `51.78% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/ActionMenuItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWN0aW9uTWVudUl0ZW0uanN4) | `0.00% <0.00%> (ø)` | |
| [...rc/dashboard/components/FilterIndicatorTooltip.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvclRvb2x0aXAuanN4) | `100.00% <0.00%> (ø)` | |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `87.50% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
| [superset-frontend/src/welcome/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvaW5kZXguanN4) | `0.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENvbXBvbmVudFdpZHRoRnJvbURyb3AuanM=) | `95.23% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.98%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.95% -4.99%
==========================================
Files 183 587 +404
Lines 17847 30460 +12613
Branches 0 3121 +3121
==========================================
+ Hits 12660 20089 +7429
- Misses 5187 10187 +5000
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.00% <ø> (?)` | |
| #python | `70.85% <ø> (-0.08%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-1.62%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `0.00% <0.00%> (ø)` | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `89.01% <0.00%> (ø)` | |
| [...nd/src/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=) | `13.79% <0.00%> (ø)` | |
| [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | `70.27% <0.00%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | `0.00% <0.00%> (ø)` | |
| ... and [397 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.59% -0.34%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 21491 +8831
- Misses 5187 8830 +3643
- Partials 0 121 +121
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.85% <ø> (?)` | |
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/FaveStar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIuanN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | `92.30% <0.00%> (ø)` | |
| [superset-frontend/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3guanN4) | `100.00% <0.00%> (ø)` | |
| [...src/dashboard/components/DeleteComponentButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0RlbGV0ZUNvbXBvbmVudEJ1dHRvbi5qc3g=) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29uZmlybVN0YXR1c0NoYW5nZS50c3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | `100.00% <0.00%> (ø)` | |
| [...set-frontend/src/explore/components/ControlRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUm93LmpzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `100.00% <0.00%> (ø)` | |
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <0.00%> (ø)` | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | `100.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...93e754e](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.90%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.91%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10158 +4971
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `93.54% <0.00%> (ø)` | |
| [superset-frontend/src/welcome/Welcome.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvV2VsY29tZS5qc3g=) | `78.57% <0.00%> (ø)` | |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `29.41% <0.00%> (ø)` | |
| [...frontend/src/components/BootstrapSliderWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQm9vdHN0cmFwU2xpZGVyV3JhcHBlci5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.85% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (ø)` | |
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `27.77% <0.00%> (ø)` | |
| [...perset-frontend/src/components/FilterBadgeIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyQmFkZ2VJY29uLmpzeA==) | `50.00% <0.00%> (ø)` | |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlck9wdGlvbi5qc3g=) | `57.69% <0.00%> (ø)` | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#discussion_r422315291
##########
File path: docs/installation.rst
##########
@@ -424,8 +562,36 @@ The connection string for PostgreSQL looks like this ::
postgresql+psycopg2://{username}:{password}@{host}:{port}/{database}
-See `psycopg2 SQLAlchemy <https://docs.sqlalchemy.org/en/13/dialects/postgresql.html#module-sqlalchemy.dialects.postgresql.psycopg2>`_.
+Additional may be configured via the ``extra`` field under ``engine_params``.
+If you would like to enable mutual SSL here is a sample configuration: ::
+
Review comment:
`.. code-block:: json`
##########
File path: docs/installation.rst
##########
@@ -424,8 +562,36 @@ The connection string for PostgreSQL looks like this ::
postgresql+psycopg2://{username}:{password}@{host}:{port}/{database}
-See `psycopg2 SQLAlchemy <https://docs.sqlalchemy.org/en/13/dialects/postgresql.html#module-sqlalchemy.dialects.postgresql.psycopg2>`_.
+Additional may be configured via the ``extra`` field under ``engine_params``.
+If you would like to enable mutual SSL here is a sample configuration: ::
+
+ {
+ "metadata_params": {},
+ "engine_params": {
+ "connect_args":{
+ "sslmode": "require",
+ "sslrootcert": "/path/to/root_cert"
+ }
+ }
+ }
+
+If the key ``sslrootcert`` is present the server's certificate will be verified to be signed by the same Certificate Authority (CA).
+If you would like to enable mutual SSL here is a sample configuration: ::
+
Review comment:
.. code-block:: json
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.80% -0.14%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 21555 +8895
- Misses 5187 8774 +3587
- Partials 0 115 +115
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.69% <ø> (?)` | |
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `23.52% <0.00%> (ø)` | |
| [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/AdhocFilter.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NGaWx0ZXIuanM=) | `97.26% <0.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `100.00% <0.00%> (ø)` | |
| [.../src/dashboard/components/DeleteComponentModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0RlbGV0ZUNvbXBvbmVudE1vZGFsLmpzeA==) | `70.58% <0.00%> (ø)` | |
| [superset-frontend/src/components/ModalTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | `96.93% <0.00%> (ø)` | |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `56.71% <0.00%> (ø)` | |
| [...-frontend/src/components/IndeterminateCheckbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `82.75% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.94%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.98% -4.95%
==========================================
Files 183 587 +404
Lines 17847 30460 +12613
Branches 0 3121 +3121
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10176 +4989
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.00% <ø> (?)` | |
| #python | `70.92% <ø> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.13% <0.00%> (-0.73%)` | :arrow_down: |
| [...t-frontend/src/SqlLab/components/TabStatusIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYlN0YXR1c0ljb24uanN4) | `85.71% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | `0.00% <0.00%> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `76.92% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `0.00% <0.00%> (ø)` | |
| [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `100.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/components/ActionMenuItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWN0aW9uTWVudUl0ZW0uanN4) | `0.00% <0.00%> (ø)` | |
| [...end/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy5qcw==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/logger/LogUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy5qcw==) | `100.00% <0.00%> (ø)` | |
| ... and [396 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.94%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.99% -4.95%
==========================================
Files 183 587 +404
Lines 17847 30460 +12613
Branches 0 3121 +3121
==========================================
+ Hits 12660 20101 +7441
- Misses 5187 10175 +4988
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.00% <ø> (?)` | |
| #python | `70.92% <ø> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.13% <0.00%> (-0.73%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `81.43% <0.00%> (ø)` | |
| [...ntend/src/dashboard/components/FilterIndicator.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvci5qc3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/showSavedQuery/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L3V0aWxzLmpz) | `100.00% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | `80.88% <0.00%> (ø)` | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | `0.00% <0.00%> (ø)` | |
| [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `22.22% <0.00%> (ø)` | |
| [superset-frontend/src/components/ErrorBoundary.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS5qc3g=) | `18.18% <0.00%> (ø)` | |
| [superset-frontend/src/logger/LogUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy5qcw==) | `100.00% <0.00%> (ø)` | |
| ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...fa01c22](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.94%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 65.98% -4.95%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20088 +7428
- Misses 5187 10170 +4983
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.86% <ø> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [...ntend/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZURhc2hib2FyZEZpbHRlcnMuanM=) | `92.30% <0.00%> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `7.14% <0.00%> (ø)` | |
| [.../src/dashboard/components/BuilderComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLmpzeA==) | `28.57% <0.00%> (ø)` | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | `98.07% <0.00%> (ø)` | |
| [...nd/src/messageToasts/components/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
| [...perset-frontend/src/messageToasts/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvYWN0aW9ucy9pbmRleC5qcw==) | `91.66% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | `0.00% <0.00%> (ø)` | |
| ... and [396 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.80% -0.14%
==========================================
Files 183 586 +403
Lines 17847 30444 +12597
Branches 0 3120 +3120
==========================================
+ Hits 12660 21555 +8895
- Misses 5187 8775 +3588
- Partials 0 114 +114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.65% <ø> (?)` | |
| #javascript | `59.06% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/dashboard/components/CodeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvZGVNb2RhbC5qc3g=) | `62.50% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupPluginsExtra.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLmpz) | `100.00% <0.00%> (ø)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.02% <0.00%> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS5qc3g=) | `77.77% <0.00%> (ø)` | |
| [superset-frontend/src/modules/AnnotationTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvQW5ub3RhdGlvblR5cGVzLmpz) | `76.47% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3VwZGF0ZUNvbXBvbmVudFBhcmVudHNMaXN0Lmpz) | `87.50% <0.00%> (ø)` | |
| [...shboard/util/charts/getFormDataWithExtraFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMuanM=) | `89.47% <0.00%> (ø)` | |
| [...dashboard/util/logging/findTopLevelComponentIds.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZFRvcExldmVsQ29tcG9uZW50SWRzLmpz) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...ead2d38](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.71% -0.22%
==========================================
Files 183 183
Lines 17847 17847
==========================================
- Hits 12660 12621 -39
- Misses 5187 5226 +39
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.90%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.91%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10158 +4971
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | `66.66% <0.00%> (ø)` | |
| [...et-frontend/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29uZmlybVN0YXR1c0NoYW5nZS50c3g=) | `100.00% <0.00%> (ø)` | |
| [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <0.00%> (ø)` | |
| [superset-frontend/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLmpzeA==) | `63.36% <0.00%> (ø)` | |
| [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <0.00%> (ø)` | |
| [superset-frontend/src/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvdXRpbHMuanM=) | `48.38% <0.00%> (ø)` | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.56% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `83.52% <0.00%> (ø)` | |
| [superset-frontend/src/messageToasts/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29uc3RhbnRzLmpz) | `100.00% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.90%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 66.02% -4.91%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 20100 +7440
- Misses 5187 10158 +4971
- Partials 0 184 +184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/dashboard/util/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbnN0YW50cy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `87.50% <0.00%> (ø)` | |
| [...perset-frontend/src/dashboard/util/isValidChild.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC5qcw==) | `90.90% <0.00%> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `7.14% <0.00%> (ø)` | |
| [...rontend/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRGaWx0ZXJzLmpz) | `88.46% <0.00%> (ø)` | |
| [superset-frontend/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3guanN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.48% <0.00%> (ø)` | |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `59.25% <0.00%> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...s/ErrorMessage/getErrorMessageComponentRegistry.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL2dldEVycm9yTWVzc2FnZUNvbXBvbmVudFJlZ2lzdHJ5LnRz) | `85.71% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...93e754e](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.81% -0.13%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 21557 +8897
- Misses 5187 8771 +3584
- Partials 0 114 +114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (?)` | |
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/util/buildFilterScopeTreeEntry.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2J1aWxkRmlsdGVyU2NvcGVUcmVlRW50cnkuanM=) | `0.00% <0.00%> (ø)` | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `68.53% <0.00%> (ø)` | |
| [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Byb3BTaGFwZXMuanN4) | `92.85% <0.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `83.03% <0.00%> (ø)` | |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `84.61% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `82.35% <0.00%> (ø)` | |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `83.11% <0.00%> (ø)` | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9767: [docs] Add SSL config options for postgres
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9767:
URL: https://github.com/apache/incubator-superset/pull/9767#issuecomment-625535362
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=h1) Report
> Merging [#9767](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9767/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9767 +/- ##
==========================================
- Coverage 70.93% 70.58% -0.35%
==========================================
Files 183 586 +403
Lines 17847 30442 +12595
Branches 0 3120 +3120
==========================================
+ Hits 12660 21489 +8829
- Misses 5187 8832 +3645
- Partials 0 121 +121
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.82% <ø> (?)` | |
| #javascript | `59.07% <ø> (?)` | |
| #python | `70.93% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/messageToasts/propShapes.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcHJvcFNoYXBlcy5qcw==) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `83.11% <0.00%> (ø)` | |
| [...dashboard/util/logging/findTopLevelComponentIds.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZFRvcExldmVsQ29tcG9uZW50SWRzLmpz) | `0.00% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | `8.62% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkuanN4) | `93.54% <0.00%> (ø)` | |
| [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Hotkeys.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSG90a2V5cy5qc3g=) | `100.00% <0.00%> (ø)` | |
| [.../src/explore/components/controls/BoundsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Cb3VuZHNDb250cm9sLmpzeA==) | `93.10% <0.00%> (ø)` | |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (ø)` | |
| [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | `97.05% <0.00%> (ø)` | |
| ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=footer). Last update [13c5b13...e333d6b](https://codecov.io/gh/apache/incubator-superset/pull/9767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org