[GitHub] [hadoop] jojochuang commented on a diff in pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

[GitBox <gi...@apache.org>]

jojochuang commented on code in PR #5013:
URL: https://github.com/apache/hadoop/pull/5013#discussion_r1005007173


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java:
##########
@@ -247,10 +247,8 @@ static RenameResult renameToInt(
       throws IOException {
     String src = srcArg;
     String dst = dstArg;
-    if (NameNode.stateChangeLog.isDebugEnabled()) {
-      NameNode.stateChangeLog.debug("DIR* NameSystem.renameTo: with options -" +
-          " " + src + " to " + dst);
-    }
+    NameNode.stateChangeLog.debug("DIR* NameSystem.renameTo: with options={} {} to {}",
+        Arrays.toString(options), src, dst);

Review Comment:
   not sure about this...
   Wouldn't it incur overhead because it has to compose a string before determining to log or not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org