You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2020/05/06 07:54:48 UTC

[GitHub] [shiro] bmhm opened a new pull request #224: (doc) Remove base64 implementation, keep UTF-8 codec by default.

bmhm opened a new pull request #224:
URL: https://github.com/apache/shiro/pull/224


   For v2.0.0, we probably do not want to maintain our own Base64 implementation.
   
   Still, the shiro implementation defaulted to UTF-8 for decoding strings, which seems to be a sane default.
   
   However, the `CryptoException` became unreachable from the Base64 class. As this is not cryptography anyway, I decided to replace it with the `IllegalArgumentException` thrown by `java.util.Base64`'s methods.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] bmhm commented on pull request #224: [SHIRO-770] Remove base64 implementation, keep UTF-8 codec by default.

Posted by GitBox <gi...@apache.org>.
bmhm commented on pull request #224:
URL: https://github.com/apache/shiro/pull/224#issuecomment-625299223


   > @bmhm can you create a Jira for this issue?
   
   SHIRO-770 - https://issues.apache.org/jira/browse/SHIRO-770


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] bdemers commented on pull request #224: (doc) Remove base64 implementation, keep UTF-8 codec by default.

Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #224:
URL: https://github.com/apache/shiro/pull/224#issuecomment-624656686


   > Build is broken because of jacip maven plugin for api incompatibility but it's normal as we move on 2.0.0 and we want to broke this.
   > I will deactivate this.
   
   +1, the config probably needs to change as a major version change in the pom _should_ allow for breaking API changes.
   But, for exactly that same reason, we don't need to be running japicmp right now anyway.
   
   Once we get closer to a beta for date for 2.x, we can generate a japicmp report and list out the API changes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] bdemers commented on pull request #224: (doc) Remove base64 implementation, keep UTF-8 codec by default.

Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #224:
URL: https://github.com/apache/shiro/pull/224#issuecomment-624657672


   @bmhm great change! PRs that remove code are my favorite 😄 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] fpapon commented on pull request #224: (doc) Remove base64 implementation, keep UTF-8 codec by default.

Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #224:
URL: https://github.com/apache/shiro/pull/224#issuecomment-624522744


   Build is broken because of jacip maven plugin for api incompatibility but it's normal as we move on 2.0.0 and we want to broke this.
   I will deactivate this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] fpapon commented on pull request #224: (doc) Remove base64 implementation, keep UTF-8 codec by default.

Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #224:
URL: https://github.com/apache/shiro/pull/224#issuecomment-624666288


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shiro] fpapon commented on pull request #224: (doc) Remove base64 implementation, keep UTF-8 codec by default.

Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #224:
URL: https://github.com/apache/shiro/pull/224#issuecomment-624835254


   @bmhm can you create a Jira for this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org