[jira] [Commented] (ZOOKEEPER-1796) Move common code from {Follower, Observer}ZooKeeperServer into LearnerZooKeeperServer

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942727#comment-13942727 ] 

Hadoop QA commented on ZOOKEEPER-1796:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12608367/ZOOKEEPER-1796.patch
  against trunk revision 1577756.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1978//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1978//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1978//console

This message is automatically generated.

> Move common code from {Follower, Observer}ZooKeeperServer into LearnerZooKeeperServer
> -------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1796
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1796
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Raul Gutierrez Segales
>            Priority: Trivial
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1796.patch
>
>
> Since ZOOKEEPER-1552 we are enabling syncProcessor in Observers, so we should have a proper shutdown() method there. Since FollowerZooKeeperServer already has one, which does the same thing that we need, move that to LearnerZooKeeperServer along with some related instance variables. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)