[GitHub] [airflow] o-nikolas commented on a diff in pull request #31746: Added config template field to EmrServerlessStartJobOperator

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #31746:
URL: https://github.com/apache/airflow/pull/31746#discussion_r1221915219


##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -963,6 +963,7 @@ class EmrServerlessStartJobOperator(BaseOperator):
 
     template_fields: Sequence[str] = (
         "application_id",
+        "config",

Review Comment:
   Can you add the `template_fields_renderers` attribute and specify `json` for this new field? That way it will render nicely in the UI. You can also add the same for `configuration_overrides` while you're at it :smile:
   ([docs](https://airflow.apache.org/docs/apache-airflow/stable/howto/custom-operator.html#templating) and [example of setting the renderers](https://github.com/apache/airflow/blob/259febee2579300f154a64bf6d24066fee494753/airflow/providers/amazon/aws/operators/sqs.py#L51-L54))



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org