You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/07 21:45:00 UTC
[jira] [Commented] (KAFKA-6146) minimize the number of triggers enqueuing PreferredReplicaLeaderElection events

    [ https://issues.apache.org/jira/browse/KAFKA-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242959#comment-16242959 ] 

ASF GitHub Bot commented on KAFKA-6146:
---------------------------------------

GitHub user onurkaraman opened a pull request:

    https://github.com/apache/kafka/pull/4189

    KAFKA-6146: minimize the number of triggers enqueuing PreferredReplicaLeaderElection events

    We currently enqueue a PreferredReplicaLeaderElection controller event in PreferredReplicaElectionHandler's handleCreation, handleDeletion, and handleDataChange. We can just enqueue the event upon znode creation and after preferred replica leader election completes. The processing of this latter enqueue will register the exist watch on PreferredReplicaElectionZNode and perform any pending preferred replica leader election that may have occurred between completion and registration.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/onurkaraman/kafka KAFKA-6146

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4189
    
----
commit d7087fec5ee00bd7a13ebe435905e85845aeb29f
Author: Onur Karaman <ok...@linkedin.com>
Date:   2017-11-07T21:19:52Z

    KAFKA-6146: minimize the number of triggers enqueuing PreferredReplicaLeaderElection events
    
    We currently enqueue a PreferredReplicaLeaderElection controller event in PreferredReplicaElectionHandler's handleCreation, handleDeletion, and handleDataChange. We can just enqueue the event upon znode creation and after preferred replica leader election completes. The processing of this latter enqueue will register the exist watch on PreferredReplicaElectionZNode and perform any pending preferred replica leader election that may have occurred between completion and registration.

----


> minimize the number of triggers enqueuing PreferredReplicaLeaderElection events
> -------------------------------------------------------------------------------
>
>                 Key: KAFKA-6146
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6146
>             Project: Kafka
>          Issue Type: Sub-task
>    Affects Versions: 1.1.0
>            Reporter: Jun Rao
>             Fix For: 1.1.0
>
>
> We currently enqueue a PreferredReplicaLeaderElection controller event in PreferredReplicaElectionHandler's handleCreation, handleDeletion, and handleDataChange. We can just enqueue the event upon znode creation and after preferred replica leader election completes. The processing of this latter enqueue will register the exist watch on PreferredReplicaElectionZNode and perform any pending preferred replica leader election that may have occurred between completion and registration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)