[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #736: GEODE-8872: added API impacts to native client

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #736:
URL: https://github.com/apache/geode-native/pull/736#discussion_r568006417



##########
File path: cppcache/src/ThinClientLocatorHelper.cpp
##########
@@ -123,7 +124,8 @@ std::shared_ptr<Serializable> ThinClientLocatorHelper::sendRequest(
     auto conn = createConnection(location);
     auto data =
         m_poolDM->getConnectionManager().getCacheImpl()->createDataOutput();
-    data.writeInt(static_cast<int32_t>(1001));  // GOSSIPVERSION
+    data.writeInt(static_cast<int32_t>(1002));  // GOSSIPVERSION

Review comment:
       Let's move this GOSSIPVERSION to a constant somewhere

##########
File path: clicache/src/PoolFactory.cpp
##########
@@ -425,6 +425,26 @@ namespace Apache
 	   }
 
 
+      PoolFactory^ PoolFactory::SetRequestLocatorInternalAddress( bool requestInternal )
+      {
+			  _GF_MG_EXCEPTION_TRY2/* due to auto replace */

Review comment:
       C++/CLI formatting looks a bit off.

##########
File path: cppcache/src/ThinClientLocatorHelper.cpp
##########
@@ -123,7 +124,8 @@ std::shared_ptr<Serializable> ThinClientLocatorHelper::sendRequest(
     auto conn = createConnection(location);
     auto data =
         m_poolDM->getConnectionManager().getCacheImpl()->createDataOutput();
-    data.writeInt(static_cast<int32_t>(1001));  // GOSSIPVERSION
+    data.writeInt(static_cast<int32_t>(1002));  // GOSSIPVERSION
+    data.writeInt(static_cast<int16_t>(125));   // GEODE 1.14.0

Review comment:
       Use `Version::getOrdinal()`. You will need to update the ordinal to 1.14.0. This also means any protocol changes from 1.0.0, the current value, to 1.14.0 need to be implemented.

##########
File path: cppcache/src/LocatorListRequest.hpp
##########
@@ -34,13 +34,16 @@ class Serializable;
 class LocatorListRequest : public ServerLocationRequest {
  private:
   std::string m_servergroup;
+  bool m_requestInternalAddress;
 
  public:
-  explicit LocatorListRequest(const std::string& servergroup = "");
+  explicit LocatorListRequest(const std::string& servergroup = "",

Review comment:
       I suspect this signature has some really strange undefined behavior and now might be a time to fix it. We should probably go a step further and fix the default value assigned to a `std::string` reference. I think the keyword `explicit` can be dropped now since there is more than one argument. Maybe we default the first argument can convert but.. 🤷  What does clang-tidy say?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org