You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by stanleyxu2005 <gi...@git.apache.org> on 2014/11/22 18:10:10 UTC
[GitHub] thrift pull request: Removed unnecessary helper function
GitHub user stanleyxu2005 opened a pull request:
https://github.com/apache/thrift/pull/280
Removed unnecessary helper function
`IfValue` is a duplicate of `System.StrUtils.IfThen`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanleyxu2005/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #280
----
commit 8708fb44657de7d8904aac508c0f2b340bda9bed
Author: Qian Xu <sx...@googlemail.com>
Date: 2014-11-22T17:10:00Z
Removed unnecessary helper function
`IfValue` is a duplicate of `System.StrUtils.IfThen`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Removed unnecessary helper function
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/280#issuecomment-64129335
You can close it, it has been merged.
At least theoretically the ASF bot should have auto-closed it anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Removed unnecessary helper function
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/280#issuecomment-64095161
Tracked in THRIFT-2847
Please have a look at http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Removed unnecessary helper function
Posted by stanleyxu2005 <gi...@git.apache.org>.
Github user stanleyxu2005 commented on the pull request:
https://github.com/apache/thrift/pull/280#issuecomment-64103261
@Jens-G Thanks for your reply. I'll follow the guide next time ^^)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Removed unnecessary helper function
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Removed unnecessary helper function
Posted by stanleyxu2005 <gi...@git.apache.org>.
Github user stanleyxu2005 closed the pull request at:
https://github.com/apache/thrift/pull/280
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Removed unnecessary helper function
Posted by stanleyxu2005 <gi...@git.apache.org>.
GitHub user stanleyxu2005 reopened a pull request:
https://github.com/apache/thrift/pull/280
Removed unnecessary helper function
`IfValue` is a duplicate of `System.StrUtils.IfThen`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanleyxu2005/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #280
----
commit 8708fb44657de7d8904aac508c0f2b340bda9bed
Author: Qian Xu <sx...@googlemail.com>
Date: 2014-11-22T17:10:00Z
Removed unnecessary helper function
`IfValue` is a duplicate of `System.StrUtils.IfThen`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---