You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2023/01/16 11:17:43 UTC
[GitHub] [mynewt-core] kasjer commented on a diff in pull request #2916: Update depracted clock source settings
kasjer commented on code in PR #2916:
URL: https://github.com/apache/mynewt-core/pull/2916#discussion_r1071123581
##########
hw/mcu/nordic/nrf51xxx/syscfg.yml:
##########
@@ -97,32 +97,49 @@ syscfg.defs:
description: 'reference mV in VDD if used'
value: 0
-# The XTAL_xxx definitions are used to set the clock source used for the low
-# frequency clock. It is required that at least one of these sources is
-# enabled (the bsp should set one of these clock sources).
+ MCU_LFCLK_SOURCE:
+ description: >
+ Selected source for low frequency clock (LFCLK).
+ value:
+ choices:
+ - LFRC # 32.768 kHz RC oscillator
+ - LFXO # 32.768 kHz crystal oscillator
+ - LFSYNTH # 32.768 kHz synthesized from HFCLK
+
+ # Deprecated settings
+
XTAL_32768:
- description: 'External 32k oscillator LF clock source.'
+ description: Use MCU_LFCLK_SOURCE instead
Review Comment:
I would be more specific in description:
```yml
description: Use "MCU_LFCLK_SOURCE: LXFO" instead
```
##########
hw/mcu/nordic/nrf51xxx/syscfg.yml:
##########
@@ -97,32 +97,49 @@ syscfg.defs:
description: 'reference mV in VDD if used'
value: 0
-# The XTAL_xxx definitions are used to set the clock source used for the low
-# frequency clock. It is required that at least one of these sources is
-# enabled (the bsp should set one of these clock sources).
+ MCU_LFCLK_SOURCE:
+ description: >
+ Selected source for low frequency clock (LFCLK).
+ value:
+ choices:
+ - LFRC # 32.768 kHz RC oscillator
+ - LFXO # 32.768 kHz crystal oscillator
+ - LFSYNTH # 32.768 kHz synthesized from HFCLK
+
+ # Deprecated settings
+
XTAL_32768:
- description: 'External 32k oscillator LF clock source.'
+ description: Use MCU_LFCLK_SOURCE instead
value: 0
restrictions:
- - "!XTAL_32768_SYNTH"
- "!XTAL_RC"
-
+ - "!XTAL_32768_SYNTH"
Review Comment:
Why reverse line order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org