[jira] [Commented] (GROOVY-9197) Groovyc fails to correctly propagate classpath entries to javac when run under JDK 11

["Eric Milles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-9197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888369#comment-16888369 ] 

Eric Milles commented on GROOVY-9197:
-------------------------------------

When {{Groovyc}} is run in forked mode, it passes all classpath entries to the Java executable, leaving off the {{--classpath}} argument of {{org.codehaus.groovy.ant.FileSystemCompilerFacade}}.  This can be seen in {{org.codehaus.groovy.ant.Groovyc.doForkCommandLineList}}.

If the classpath was passed to {{FileSystemCompilerFacade}}, they would be added to the {{CompilerConfiguration}} and it would not matter what the class loader hierarchy looked like.  However, enough classpath needs to be passed to java so that it can successfully run {{FileSystemCompilerFacade}}.

> Groovyc fails to correctly propagate classpath entries to javac when run under JDK 11
> -------------------------------------------------------------------------------------
>
>                 Key: GROOVY-9197
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9197
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.5.7
>            Reporter: Artsiom Matronkin
>            Priority: Major
>         Attachments: groovycCpIssue.zip
>
>
> *Repro Steps:*
>  * unpack attached zip
>  * ensure CompileAntScript.xml references the version of groovy you have locally
>  * ensure JAVA_HOME is referencing JDK 11
>  * execute CompileAntScript.xml via Ant (ensure it is executed by JDK 11)
> *Actual Result:* 
> _[compile] C:\dev\workspace\search0625_11\groovycIssue\src\org_
>  _[compile] \groovy\issue\TestCompile.java:3: error: package org.apache.commons.lang3 does not exist_
>  _[compile] import static org.apache.commons.lang3_
>  _[compile] .StringUtils.isEmpty;_
>  
> Try running same ant script via JDK 8 and it will compile successfully.
>  
> *Investigation Details:*
> Looking into groovy codebase it seems there is a bug/issue in how org.codehaus.groovy.tools.javac.JavacJavaCompiler.java accumulates classpath entries which should be passed to javac:
>   
> {code:java}
> // append classpath if not already defined
> if (!hadClasspath) {
>     // add all classpaths that compilation unit sees
>     List<String> paths = new ArrayList<String>(config.getClasspath());
>     ClassLoader cl = parentClassLoader;
>     while (cl != null) {
>         if (cl instanceof URLClassLoader) {
>             for (URL u : ((URLClassLoader) cl).getURLs()) {
>                 try {
>                     paths.add(new File(u.toURI()).getPath());
>                 } catch (URISyntaxException e) {
>                     // ignore it
>                 }
>             }
>         }
>         cl = cl.getParent();
>     }
> {code}
>  
> It iterates over hierarchy of classloaders and *assumes AppClassLoader is an instance of URLClassLoader*. This assumption was correct in Java 8 but is not correct in Java 11 ([https://blog.codefx.org/java/java-11-migration-guide/]   - ‘Casting to URLClassLoader’ chapter). Thus most of jars are not passed to javac as classpath and compilation fails.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)