You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2024/01/05 07:27:40 UTC
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20863
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
Since resolve_minidumps.py's call to minidump_stackwalk can go haywire
due to bad symbols in shared libraries, this adds a fallback mechanism
where it tries again with a "safe" list of shared libraries. These are
limited to the ones that make the most difference in resolving minidumps
(libc, libstdc++, and libjvm). The list of safe libraries can be
customized via the --safe_library_list.
Testing:
- Verified that this uses the fallback on Centos 7 and resolves
the minidumps successfully.
Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
---
M bin/resolve_minidumps.py
1 file changed, 71 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/20863/1
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14894/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Jan 2024 04:40:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20863/1/bin/resolve_minidumps.py
File bin/resolve_minidumps.py:
http://gerrit.cloudera.org:8080/#/c/20863/1/bin/resolve_minidumps.py@423
PS1, Line 423: return
> Good idea, added the traceback for the exception
Done
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 18:42:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20863
to look at the new patch set (#3).
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
Since resolve_minidumps.py's call to minidump_stackwalk can go haywire
due to bad symbols in shared libraries, this adds a fallback mechanism
where it tries again with a "safe" list of shared libraries. These are
limited to the ones that make the most difference in resolving minidumps
(libc, libstdc++, and libjvm). The list of safe libraries can be
customized via the --safe_library_list.
Testing:
- Verified that this uses the fallback on Centos 7 and resolves
the minidumps successfully.
Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
---
M bin/resolve_minidumps.py
1 file changed, 73 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/20863/3
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jan 2024 18:51:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
Since resolve_minidumps.py's call to minidump_stackwalk can go haywire
due to bad symbols in shared libraries, this adds a fallback mechanism
where it tries again with a "safe" list of shared libraries. These are
limited to the ones that make the most difference in resolving minidumps
(libc, libstdc++, and libjvm). The list of safe libraries can be
customized via the --safe_library_list.
Testing:
- Verified that this uses the fallback on Centos 7 and resolves
the minidumps successfully.
Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Reviewed-on: http://gerrit.cloudera.org:8080/20863
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/resolve_minidumps.py
1 file changed, 73 insertions(+), 21 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved
Joe McDonnell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14887/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jan 2024 07:55:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20863/1/bin/resolve_minidumps.py
File bin/resolve_minidumps.py:
http://gerrit.cloudera.org:8080/#/c/20863/1/bin/resolve_minidumps.py@423
PS1, Line 423: except Exception:
Might be useful to dump the exception as well.
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jan 2024 22:59:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20863
to look at the new patch set (#2).
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
Since resolve_minidumps.py's call to minidump_stackwalk can go haywire
due to bad symbols in shared libraries, this adds a fallback mechanism
where it tries again with a "safe" list of shared libraries. These are
limited to the ones that make the most difference in resolving minidumps
(libc, libstdc++, and libjvm). The list of safe libraries can be
customized via the --safe_library_list.
Testing:
- Verified that this uses the fallback on Centos 7 and resolves
the minidumps successfully.
Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
---
M bin/resolve_minidumps.py
1 file changed, 73 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/20863/2
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20863/1/bin/resolve_minidumps.py
File bin/resolve_minidumps.py:
http://gerrit.cloudera.org:8080/#/c/20863/1/bin/resolve_minidumps.py@423
PS1, Line 423: return
> Might be useful to dump the exception as well.
Good idea, added the traceback for the exception
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Jan 2024 04:13:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20863/2/bin/resolve_minidumps.py
File bin/resolve_minidumps.py:
http://gerrit.cloudera.org:8080/#/c/20863/2/bin/resolve_minidumps.py@424
PS2, Line 424: e
flake8: F841 local variable 'e' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Jan 2024 04:11:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve minidumps.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20863 )
Change subject: IMPALA-12643 (part 2): Fallback to safe libraries on error in resolve_minidumps.py
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/14893/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20863
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb4c9f65f9c27bb3b86c7ff2f3a6a48e258ef01
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Jan 2024 04:37:16 +0000
Gerrit-HasComments: No