You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2018/09/27 10:05:37 UTC

[GitHub] N0ps32 opened a new issue #1800: Copyright headers are being wrongfully removed by rewrite_javascript

N0ps32 opened a new issue #1800: Copyright headers are being wrongfully removed by rewrite_javascript 
URL: https://github.com/apache/incubator-pagespeed-mod/issues/1800
 
 
   Copyright header must always stay in place when minifying Javascript, however that is not the case making this filter completely useless for anybody using 3rd party code.
   
   Example:
   ```
   /*! Chosen v1.8.2 | (c) 2011-2017 by Harvest | MIT License, https://github.com/harvesthq/chosen/blob/master/LICENSE.md */
     
   /**
    * @licence MIT (c) Chosen v1.8.2 | (c) 2011-2017 by Harvest | MIT License, https://github.com/harvesthq/chosen/blob/master/LICENSE.md
    */
   ```
   
   Both of those comments get removed and they should not be. Using @licence or /*! to denote copyright headers is very common in the javascript community and supported by pretty much any packer out there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services