You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by yao lei <le...@163.com> on 2017/03/17 07:29:53 UTC
Review Request 57721: Custom properties of Alert Target are not reset
after last Alert Target being created
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57721/
-----------------------------------------------------------
Review request for Ambari, Andrii Babiichuk, Alexandr Antonenko, Oleg Nechiporenko, and Richard Zang.
Bugs: AMBARI-20484
https://issues.apache.org/jira/browse/AMBARI-20484
Repository: ambari
Description
-------
Steps to reproduce:
1.Open Alerts / Actions / Manage Notifications
2.Click + buttion and save a new alert target with any custom properties like (a1,b1) and (a2,b2)
3.Click + buttion again,at the bottom of popup, you will still find the custom properties which belong to the last alert target.
Solution:
We should reset custom proepertis before creating a new Alert Target.
Diffs
-----
ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js f470f08
ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js 15b4da3
Diff: https://reviews.apache.org/r/57721/diff/1/
Testing
-------
mvn test
20580 passing (36s)
153 pending
Thanks,
yao lei