You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/12 06:52:13 UTC

[GitHub] [superset] akshgpt7 opened a new pull request #13592: Refactor code quality issues

akshgpt7 opened a new pull request #13592:
URL: https://github.com/apache/superset/pull/13592


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Hey, I'm a Developer Outreach at [DeepSource](https:/deepsource.io/) and ran DeepSource analysis on my fork of the repo. It found some interesting [code quality improvements](https://deepsource.io/gh/akshgpt7/superset/) to consider.
   
   This PR fixes a few of the issues detected for you to assess if it is right for you.
   Happy to provide the tweaks separately otherwise :)
   
   **Summary of changes:**
   - Refactor unnecessary use of comprehension.
   - Remove unnecessary generator.
   - Fix dangerous default arguments.
   - Iterate directly over dictionary instead of using `dict.keys()`.
   - Remove re-imported modules.
   - Add `.deepsource.toml` file for continuous analysis on bug risks/performance/code-quality issues on new changes.
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (a6a8eba) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.37%`.
   > The diff coverage is `68.67%`.
   
   > :exclamation: Current head a6a8eba differs from pull request most recent head 5fc45bd. Consider uploading reports for the commit 5fc45bd to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   70.91%   -5.38%     
   ==========================================
     Files         910      843      -67     
     Lines       46310    41969    -4341     
     Branches     5613     4393    -1220     
   ==========================================
   - Hits        35330    29763    -5567     
   - Misses      10816    12206    +1390     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.43% <42.56%> (+1.28%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.56% <91.80%> (+0.20%)` | :arrow_up: |
   | postgres | `80.57% <92.36%> (+0.18%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.62% <92.55%> (-0.27%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `23.46% <0.00%> (-35.26%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.83%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (+1.92%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `70.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
   | ... and [662 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...5fc45bd](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud commented on a change in pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13592:
URL: https://github.com/apache/superset/pull/13592#discussion_r598143682



##########
File path: tests/dict_import_export_tests.py
##########
@@ -66,8 +66,12 @@ def tearDownClass(cls):
         cls.delete_imports()
 
     def create_table(
-        self, name, schema="", id=0, cols_names=[], cols_uuids=None, metric_names=[]
+        self, name, schema="", id=0, cols_names=None, cols_uuids=None, metric_names=None

Review comment:
       Pylint is already capable of capture this error. We just didn't enable it for tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (a6a8eba) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.19%`.
   > The diff coverage is `68.77%`.
   
   > :exclamation: Current head a6a8eba differs from pull request most recent head 5fc45bd. Consider uploading reports for the commit 5fc45bd to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.10%   -5.20%     
   ==========================================
     Files         910      843      -67     
     Lines       46310    41969    -4341     
     Branches     5613     4393    -1220     
   ==========================================
   - Hits        35330    29840    -5490     
   - Misses      10816    12129    +1313     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.43% <42.56%> (+1.28%)` | :arrow_up: |
   | hive | `80.24% <92.36%> (+0.20%)` | :arrow_up: |
   | javascript | `?` | |
   | mysql | `80.56% <91.80%> (+0.20%)` | :arrow_up: |
   | postgres | `80.57% <92.36%> (+0.18%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.93% <92.73%> (+0.04%)` | :arrow_up: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `23.46% <0.00%> (-35.26%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.83%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (+1.92%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `70.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
   | ... and [658 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...5fc45bd](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (eb8a0ab) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.31%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   70.97%   -5.32%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    41393    -4917     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    29377    -5953     
   - Misses      10816    12016    +1200     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.60%)` | :arrow_up: |
   | hive | `80.03% <100.00%> (ø)` | |
   | javascript | `?` | |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `80.06% <100.00%> (+<0.01%)` | :arrow_up: |
   | python | `80.52% <100.00%> (-0.37%)` | :arrow_down: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [512 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (a6a8eba) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.09%`.
   > The diff coverage is `68.77%`.
   
   > :exclamation: Current head a6a8eba differs from pull request most recent head 5fc45bd. Consider uploading reports for the commit 5fc45bd to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.19%   -5.10%     
   ==========================================
     Files         910      843      -67     
     Lines       46310    41997    -4313     
     Branches     5613     4393    -1220     
   ==========================================
   - Hits        35330    29901    -5429     
   - Misses      10816    12096    +1280     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.43% <42.56%> (+1.28%)` | :arrow_up: |
   | hive | `80.25% <92.36%> (+0.22%)` | :arrow_up: |
   | javascript | `?` | |
   | mysql | `80.56% <91.80%> (+0.20%)` | :arrow_up: |
   | postgres | `80.57% <92.36%> (+0.18%)` | :arrow_up: |
   | presto | `80.26% <90.68%> (+0.20%)` | :arrow_up: |
   | python | `81.08% <92.73%> (+0.19%)` | :arrow_up: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `23.46% <0.00%> (-35.26%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.83%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (+1.92%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `70.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
   | ... and [651 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...5fc45bd](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `4.59%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.69%   -4.60%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    42761    -3549     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    30659    -4671     
   - Misses      10816    12102    +1286     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.59%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `81.05% <100.00%> (+0.70%)` | :arrow_up: |
   | postgres | `81.11% <100.00%> (+0.72%)` | :arrow_up: |
   | presto | `?` | |
   | python | `81.21% <100.00%> (+0.32%)` | :arrow_up: |
   | sqlite | `80.75% <100.00%> (+0.73%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [507 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] akshgpt7 commented on a change in pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
akshgpt7 commented on a change in pull request #13592:
URL: https://github.com/apache/superset/pull/13592#discussion_r598145379



##########
File path: tests/dict_import_export_tests.py
##########
@@ -66,8 +66,12 @@ def tearDownClass(cls):
         cls.delete_imports()
 
     def create_table(
-        self, name, schema="", id=0, cols_names=[], cols_uuids=None, metric_names=[]
+        self, name, schema="", id=0, cols_names=None, cols_uuids=None, metric_names=None

Review comment:
       In addition to the pylint rules, DeepSource also detects some performance issues, bug-risks and security vulnerabilities. Also, you can Autofix them with just one click. DeepSource will flag only those changes which occur in a particular patch/PR, which will make the code review process faster.
   Just like the pylint config, you can selectively choose which issues to ignore in DeepSource too (test files in this case).
   Feel free to reach out or check out the [docs](https://deepsource.io/docs/) if you have any questions :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (b4379fb) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `6.51%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   69.77%   -6.52%     
   ==========================================
     Files         910      823      -87     
     Lines       46310    41201    -5109     
     Branches     5613     4224    -1389     
   ==========================================
   - Hits        35330    28747    -6583     
   - Misses      10816    12454    +1638     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.53% <ø> (-1.62%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <ø> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <ø> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.49% <ø> (-0.40%)` | :arrow_down: |
   | sqlite | `80.02% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [512 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `4.51%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.77%   -4.52%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    42761    -3549     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    30691    -4639     
   - Misses      10816    12070    +1254     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.59%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `81.05% <100.00%> (+0.70%)` | :arrow_up: |
   | postgres | `81.11% <100.00%> (+0.72%)` | :arrow_up: |
   | presto | `80.10% <100.00%> (+0.04%)` | :arrow_up: |
   | python | `81.33% <100.00%> (+0.44%)` | :arrow_up: |
   | sqlite | `80.75% <100.00%> (+0.73%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [505 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **increase** coverage by `4.18%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   + Coverage   76.29%   80.47%   +4.18%     
   ==========================================
     Files         910      304     -606     
     Lines       46310    24759   -21551     
     Branches     5613        0    -5613     
   ==========================================
   - Hits        35330    19926   -15404     
   + Misses      10816     4833    -5983     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <100.00%> (ø)` | |
   | postgres | `80.39% <100.00%> (ø)` | |
   | presto | `?` | |
   | python | `80.47% <100.00%> (-0.41%)` | :arrow_down: |
   | sqlite | `80.02% <100.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.42%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
   | [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | | |
   | [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | | |
   | [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | | |
   | ... and [603 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (f1f3f08) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `7.03%`.
   > The diff coverage is `89.24%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   69.25%   -7.04%     
   ==========================================
     Files         910      776     -134     
     Lines       46310    38447    -7863     
     Branches     5613     3602    -2011     
   ==========================================
   - Hits        35330    26628    -8702     
   - Misses      10816    11819    +1003     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `48.80% <0.00%> (-6.35%)` | :arrow_down: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <87.77%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <92.22%> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.49% <92.22%> (-0.40%)` | :arrow_down: |
   | sqlite | `80.02% <87.77%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `22.44% <0.00%> (-65.31%)` | :arrow_down: |
   | [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
   | [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
   | [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
   | [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
   | [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
   | [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `22.22% <ø> (-77.78%)` | :arrow_down: |
   | ... and [544 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.34%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   70.94%   -5.35%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    41393    -4917     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    29366    -5964     
   - Misses      10816    12027    +1211     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.59%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <100.00%> (ø)` | |
   | postgres | `80.39% <100.00%> (ø)` | |
   | presto | `?` | |
   | python | `80.47% <100.00%> (-0.41%)` | :arrow_down: |
   | sqlite | `80.02% <100.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [501 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (a6a8eba) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.17%`.
   > The diff coverage is `68.77%`.
   
   > :exclamation: Current head a6a8eba differs from pull request most recent head 5fc45bd. Consider uploading reports for the commit 5fc45bd to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.11%   -5.18%     
   ==========================================
     Files         910      843      -67     
     Lines       46310    41997    -4313     
     Branches     5613     4393    -1220     
   ==========================================
   - Hits        35330    29867    -5463     
   - Misses      10816    12130    +1314     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.43% <42.56%> (+1.28%)` | :arrow_up: |
   | hive | `80.25% <92.36%> (+0.22%)` | :arrow_up: |
   | javascript | `?` | |
   | mysql | `80.56% <91.80%> (+0.20%)` | :arrow_up: |
   | postgres | `80.57% <92.36%> (+0.18%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.95% <92.73%> (+0.06%)` | :arrow_up: |
   | sqlite | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `23.46% <0.00%> (-35.26%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `5.68% <0.00%> (-62.83%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `49.09% <0.00%> (+1.92%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <ø> (-82.49%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `70.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...rc/common/hooks/useChangeEffect/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QvdXNlQ2hhbmdlRWZmZWN0LnRz) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/hooks/usePrevious/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy91c2VQcmV2aW91cy50cw==) | `100.00% <ø> (ø)` | |
   | [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
   | ... and [651 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...5fc45bd](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] stale[bot] commented on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-859200791


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13592:
URL: https://github.com/apache/superset/pull/13592#discussion_r597938485



##########
File path: .deepsource.toml
##########
@@ -0,0 +1,22 @@
+version = 1

Review comment:
       you should add a license info for the PR to pass.
   
   but in general the decision to use deepsource.toml  library as a standard for code is a topic that needs to be considered  bc Superset already has a set of standards for python that are being validated at the pre-commit check 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (f1f3f08) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `3.25%`.
   > The diff coverage is `91.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   73.03%   -3.26%     
   ==========================================
     Files         910      779     -131     
     Lines       46310    38502    -7808     
     Branches     5613     3626    -1987     
   ==========================================
   - Hits        35330    28120    -7210     
   + Misses      10816    10382     -434     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `59.51% <66.66%> (+4.35%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <87.77%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <92.22%> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.49% <92.22%> (-0.40%)` | :arrow_down: |
   | sqlite | `80.02% <87.77%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
   | [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
   | [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
   | [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
   | [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
   | [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `22.22% <ø> (-77.78%)` | :arrow_down: |
   | [.../controls/MetricControl/MetricDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25PcHRpb24uanN4) | `18.18% <ø> (-63.64%)` | :arrow_down: |
   | ... and [531 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (b4379fb) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.33%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   70.96%   -5.34%     
   ==========================================
     Files         910      828      -82     
     Lines       46310    41450    -4860     
     Branches     5613     4307    -1306     
   ==========================================
   - Hits        35330    29413    -5917     
   - Misses      10816    12037    +1221     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.73% <ø> (+1.58%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <ø> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <ø> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.49% <ø> (-0.40%)` | :arrow_down: |
   | sqlite | `80.02% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
   | ... and [512 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (b4379fb) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.14%   -5.15%     
   ==========================================
     Files         910      828      -82     
     Lines       46310    41450    -4860     
     Branches     5613     4307    -1306     
   ==========================================
   - Hits        35330    29488    -5842     
   - Misses      10816    11962    +1146     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.73% <ø> (+1.58%)` | :arrow_up: |
   | hive | `80.03% <ø> (+<0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | mysql | `80.35% <ø> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <ø> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.79% <ø> (-0.09%)` | :arrow_down: |
   | sqlite | `80.02% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
   | ... and [509 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (f1f3f08) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.33%`.
   > The diff coverage is `85.71%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   70.95%   -5.34%     
   ==========================================
     Files         910      828      -82     
     Lines       46310    41450    -4860     
     Branches     5613     4307    -1306     
   ==========================================
   - Hits        35330    29412    -5918     
   - Misses      10816    12038    +1222     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.73% <46.66%> (+1.57%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <87.77%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <92.22%> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.49% <92.22%> (-0.40%)` | :arrow_down: |
   | sqlite | `80.02% <87.77%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...end/src/SqlLab/components/TemplateParamsEditor.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLnRzeA==) | `5.55% <0.00%> (ø)` | |
   | [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `44.00% <ø> (-16.00%)` | :arrow_down: |
   | [.../controls/FilterControl/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXIuanN4) | `10.00% <ø> (-48.00%)` | :arrow_down: |
   | [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `3.33% <ø> (-71.51%)` | :arrow_down: |
   | [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `6.66% <ø> (-56.67%)` | :arrow_down: |
   | [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.45%)` | :arrow_down: |
   | [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ponents/controls/MetricControl/AggregateOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FnZ3JlZ2F0ZU9wdGlvbi5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `22.22% <ø> (-77.78%)` | :arrow_down: |
   | ... and [528 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `4.61%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.67%   -4.62%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    42761    -3549     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    30647    -4683     
   - Misses      10816    12114    +1298     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.59%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `81.05% <100.00%> (+0.70%)` | :arrow_up: |
   | postgres | `80.39% <100.00%> (ø)` | |
   | presto | `?` | |
   | python | `81.16% <100.00%> (+0.28%)` | :arrow_up: |
   | sqlite | `80.02% <100.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [507 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (b4379fb) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.21%   -5.08%     
   ==========================================
     Files         910      828      -82     
     Lines       46310    41450    -4860     
     Branches     5613     4307    -1306     
   ==========================================
   - Hits        35330    29517    -5813     
   - Misses      10816    11933    +1117     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.73% <ø> (+1.58%)` | :arrow_up: |
   | hive | `80.03% <ø> (+<0.01%)` | :arrow_up: |
   | javascript | `?` | |
   | mysql | `80.35% <ø> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <ø> (+0.01%)` | :arrow_up: |
   | presto | `80.08% <ø> (+0.03%)` | :arrow_up: |
   | python | `80.91% <ø> (+0.02%)` | :arrow_up: |
   | sqlite | `80.02% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
   | ... and [508 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `4.51%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.77%   -4.52%     
   ==========================================
     Files         910      779     -131     
     Lines       46310    38446    -7864     
     Branches     5613     3623    -1990     
   ==========================================
   - Hits        35330    27596    -7734     
   - Misses      10816    10850      +34     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.03% <ø> (+0.88%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <100.00%> (ø)` | |
   | postgres | `80.39% <100.00%> (ø)` | |
   | presto | `?` | |
   | python | `80.47% <100.00%> (-0.41%)` | :arrow_down: |
   | sqlite | `80.02% <100.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [515 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `4.60%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.68%   -4.61%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    42761    -3549     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    30655    -4675     
   - Misses      10816    12106    +1290     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.59%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `81.05% <100.00%> (+0.70%)` | :arrow_up: |
   | postgres | `80.39% <100.00%> (ø)` | |
   | presto | `?` | |
   | python | `81.19% <100.00%> (+0.31%)` | :arrow_up: |
   | sqlite | `80.75% <100.00%> (+0.73%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [507 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] akshgpt7 closed pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
akshgpt7 closed pull request #13592:
URL: https://github.com/apache/superset/pull/13592


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] akshgpt7 closed pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
akshgpt7 closed pull request #13592:
URL: https://github.com/apache/superset/pull/13592


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `5.34%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   70.94%   -5.35%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    41393    -4917     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    29366    -5964     
   - Misses      10816    12027    +1211     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.59%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <100.00%> (ø)` | |
   | postgres | `80.39% <100.00%> (ø)` | |
   | presto | `?` | |
   | python | `80.47% <100.00%> (-0.41%)` | :arrow_down: |
   | sqlite | `80.02% <100.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [501 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...559510a](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (b4379fb) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **increase** coverage by `4.20%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   + Coverage   76.29%   80.49%   +4.20%     
   ==========================================
     Files         910      304     -606     
     Lines       46310    24812   -21498     
     Branches     5613        0    -5613     
   ==========================================
   - Hits        35330    19973   -15357     
   + Misses      10816     4839    -5977     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <ø> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <ø> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.49% <ø> (-0.40%)` | :arrow_down: |
   | sqlite | `80.02% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.24%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <0.00%> (-0.04%)` | :arrow_down: |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | | |
   | ... and [610 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (f1f3f08) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **increase** coverage by `4.20%`.
   > The diff coverage is `92.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   + Coverage   76.29%   80.49%   +4.20%     
   ==========================================
     Files         910      304     -606     
     Lines       46310    24812   -21498     
     Branches     5613        0    -5613     
   ==========================================
   - Hits        35330    19973   -15357     
   + Misses      10816     4839    -5977     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `80.35% <87.77%> (+<0.01%)` | :arrow_up: |
   | postgres | `80.41% <92.22%> (+0.01%)` | :arrow_up: |
   | presto | `?` | |
   | python | `80.49% <92.22%> (-0.40%)` | :arrow_down: |
   | sqlite | `80.02% <87.77%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <92.30%> (-6.24%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <93.33%> (-0.04%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <100.00%> (-0.39%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `94.44% <100.00%> (+1.76%)` | :arrow_up: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `93.33% <100.00%> (+1.49%)` | :arrow_up: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.51% <100.00%> (+0.45%)` | :arrow_up: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.38% <100.00%> (+0.03%)` | :arrow_up: |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.38% <100.00%> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.67% <100.00%> (+0.11%)` | :arrow_up: |
   | ... and [596 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 commented on a change in pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #13592:
URL: https://github.com/apache/superset/pull/13592#discussion_r597936223



##########
File path: .deepsource.toml
##########
@@ -0,0 +1,22 @@
+version = 1

Review comment:
       ```suggestion
   #
   # Licensed to the Apache Software Foundation (ASF) under one or more
   # contributor license agreements.  See the NOTICE file distributed with
   # this work for additional information regarding copyright ownership.
   # The ASF licenses this file to You under the Apache License, Version 2.0
   # (the "License"); you may not use this file except in compliance with
   # the License.  You may obtain a copy of the License at
   #
   #    http://www.apache.org/licenses/LICENSE-2.0
   #
   # Unless required by applicable law or agreed to in writing, software
   # distributed under the License is distributed on an "AS IS" BASIS,
   # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   # See the License for the specific language governing permissions and
   # limitations under the License.
   #
   
   version = 1
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] edited a comment on pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13592:
URL: https://github.com/apache/superset/pull/13592#issuecomment-797284672


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=h1) Report
   > Merging [#13592](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=desc) (559510a) into [master](https://codecov.io/gh/apache/superset/commit/d439da2fe00c0a16edfec3fb5354d8e8f4da470b?el=desc) (d439da2) will **decrease** coverage by `4.51%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13592/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13592      +/-   ##
   ==========================================
   - Coverage   76.29%   71.77%   -4.52%     
   ==========================================
     Files         910      827      -83     
     Lines       46310    42761    -3549     
     Branches     5613     4300    -1313     
   ==========================================
   - Hits        35330    30691    -4639     
   - Misses      10816    12070    +1254     
   + Partials      164        0     -164     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `56.75% <ø> (+1.59%)` | :arrow_up: |
   | hive | `?` | |
   | javascript | `?` | |
   | mysql | `81.05% <100.00%> (+0.70%)` | :arrow_up: |
   | postgres | `81.11% <100.00%> (+0.72%)` | :arrow_up: |
   | presto | `80.10% <100.00%> (+0.04%)` | :arrow_up: |
   | python | `81.33% <100.00%> (+0.44%)` | :arrow_up: |
   | sqlite | `80.75% <100.00%> (+0.73%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/dataframe.py](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `91.66% <100.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [505 more](https://codecov.io/gh/apache/superset/pull/13592/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=footer). Last update [d439da2...10ebae6](https://codecov.io/gh/apache/superset/pull/13592?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] akshgpt7 commented on a change in pull request #13592: chore: Refactor code quality issues

Posted by GitBox <gi...@apache.org>.
akshgpt7 commented on a change in pull request #13592:
URL: https://github.com/apache/superset/pull/13592#discussion_r598110847



##########
File path: .deepsource.toml
##########
@@ -0,0 +1,22 @@
+version = 1

Review comment:
       @amitmiran137 DeepSource is a static analysis tool, which along with code style, also detects bug-risks, performance issues and security vulnerabilities.
   It helps speeding up the code reviewing process. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org