You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/10 08:13:09 UTC
Review Request 43417: Windows: Marked functions in headers `inline`
to avoid linker errors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
Windows: Marked functions in headers `inline` to avoid linker errors.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
Diff: https://reviews.apache.org/r/43417/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43417: Windows: Marked functions in headers
`inline` to avoid linker errors.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/#review118881
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 9, 2016, 11:13 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43417/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 11:13 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Marked functions in headers `inline` to avoid linker errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
>
> Diff: https://reviews.apache.org/r/43417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43417: Windows: Marked functions in headers
`inline` to avoid linker errors.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/#review119936
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43417/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 12:59 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Marked functions in headers `inline` to avoid linker errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
>
> Diff: https://reviews.apache.org/r/43417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43417: Windows: Marked functions in headers
`inline` to avoid linker errors.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/#review120621
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43417/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 12:59 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Marked functions in headers `inline` to avoid linker errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
>
> Diff: https://reviews.apache.org/r/43417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43417: Windows: Marked functions in headers
`inline` to avoid linker errors.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/#review120004
-----------------------------------------------------------
Ship it!
Ship It!
- Daniel Pravat
On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43417/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 12:59 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Marked functions in headers `inline` to avoid linker errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
>
> Diff: https://reviews.apache.org/r/43417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43417: Windows: Marked functions in headers
`inline` to avoid linker errors.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 12:59 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
Windows: Marked functions in headers `inline` to avoid linker errors.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
Diff: https://reviews.apache.org/r/43417/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43417: Windows: Marked functions in headers
`inline` to avoid linker errors.
Posted by M Lawindi <ml...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43417/#review118933
-----------------------------------------------------------
Ship it!
Ship It!
- M Lawindi
On Feb. 10, 2016, 7:13 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43417/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 7:13 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Marked functions in headers `inline` to avoid linker errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp 046388189823c0c41ce6cc135d5d3838e9131087
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5
>
> Diff: https://reviews.apache.org/r/43417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>