You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/12/04 02:44:51 UTC
[GitHub] [echarts] tomatosqq opened a new issue #16169: [Feature]
tomatosqq opened a new issue #16169:
URL: https://github.com/apache/echarts/issues/16169
### What problem does this feature solve?
echarts tree 如何点击lable触发点击事件但是不收起子级 点击symbol才收起 能分隔开吗，因为有个功能是点击label时去获取详情展示弹窗 但是不要收起二级树
### What does the proposed API look like?
echarts tree 如何点击lable触发点击事件但是不收起子级 点击symbol才收起 能分隔开吗，因为有个功能是点击label时去获取详情展示弹窗 但是不要收起二级树
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] fuchunhui commented on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
fuchunhui commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1048691992
> It should provide a `nodeClick` option with values of `false | 'expand' | 'link'` similar to [treemap series](https://echarts.apache.org/en/option.html#series-treemap.nodeClick).
some questions:
1. add `nodeClick` or update `expandAndCollapse`?
2. if used `expandAndCollapse`, renamed to `nodeClick`?
3. if used `expandAndCollapse`, how to ensure api compatibility, where can i refer to?
```
{
expandAndCollapse: true
}
```
as same as
```
{
expandAndCollapse: 'expand'
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] fuchunhui edited a comment on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
fuchunhui edited a comment on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1065909532
I thought about it carefully, but I still have a little doubt.
`expandAndCollapse ` is not only initialization, but also interactive behavior. It supports collapses and expands interaction of nodes. What I'm confused about now is how to ensure the coexistence of the two and who has the higher priority.
Case one:
```javascript
{
expandAndCollapse: true,
nodeClick: false
}
```
Click the node, what will happen.
Case two:
```javascript
{
expandAndCollapse: false,
nodeClick: true
}
```
What 's the result?
and Case three:
```javascript
{
expandAndCollapse: true,
nodeClick: 'link'
}
```
link to target or expand node, even both.
Or other solutions, remove the interaction of `expandAndCollapse`, it only controls nodes on init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #16169: [Feature]
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-985970930
Could you please describe the feature in short in your title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #16169: [Feature]
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-985952914
@tomatosqq It seems you are not using English, I've helped translate the content automatically. To make your issue understood by more people and get helped, we'd like to suggest using English next time. 🤗
<details><summary><b>TRANSLATED</b></summary><br>
**BODY**
### What problem does this feature solve?
echarts tree How to click on the label to trigger a click event but not to close the child. Click on the symbol to close it. Can it be separated? Because there is a function to get the detailed display pop-up window when you click on the label, but don’t close the secondary tree
### What does the proposed API look like?
echarts tree How to click on the label to trigger a click event but not to close the child. Click on the symbol to close it. Can it be separated? Because there is a function to get the detailed display pop-up window when you click on the label, but don’t close the secondary tree
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1064806354
I think maybe use a new option `nodeClick` is a better solution. `expandAndCollapse` controls whether nodes collapse if there are too many nodes after `setOption`, while what we are looking for in this issue is the expand-and-collapse behavior on node clicking rather than on init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] fuchunhui commented on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
fuchunhui commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1069109675
I sort out all opinions.
1. add `nodeClick` option with values of false | 'expand' | 'link' similar to [treemap series](https://echarts.apache.org/en/option.html#series-treemap.nodeClick).
2. use `collapsible / expandable` controls 'the state of node expand'.
3. deprecate `expandAndCollapse` & cover the bottom😆 & warning.
am I?
like to be this
```
{
nodeClick: false // false | 'expand' | 'link'
expandable: true // boolean
}
```
Case 1
```
nodeClick: false
```
when clicking node, chart do nothing, no event, no expand.
Case 2
```
nodeClick: 'expand'
expandable: true
```
chart dispatch action 'treeExpandAndCollapse', toggle `node.isExpand`
Case 3
```
nodeClick: 'expand'
expandable: false
```
only dispatch action `treeExpandAndCollapse`, no toggle.
Case 4
```
nodeClick: 'link'
```
link to url, ignore `expandable`.
Finally, how to control initialization?
```
const expandAndCollapse = option.expandAndCollapse;
const expandTreeDepth = (expandAndCollapse && option.initialTreeDepth >= 0)
? option.initialTreeDepth
: treeDepth;
```
remove expandAndCollapse, decide by `initialTreeDepth >= 0` only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #16169: echarts tree click on the label to trigger a click event and get Node information but not to close the child. when Click on the symbol to close it
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-993123916
It should provide a `nodeClick` option with values of `false | 'expand' | 'link'` similar to [treemap series](https://echarts.apache.org/en/option.html#series-treemap.nodeClick).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] fuchunhui edited a comment on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
fuchunhui edited a comment on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1065909532
I thought about it carefully, but I still have a little doubt.
`expandAndCollapse ` is not only initialization, but also interactive behavior. It supports collapses and expands interaction of nodes. What I'm confused about now is how to ensure the coexistence of the two and who has the higher priority.
Case one:
```javascript
{
expandAndCollapse: true,
nodeClick: false
}
```
Click the node, what will happen.
Case two:
```javascript
{
expandAndCollapse: false,
nodeClick: true
}
```
What 's the result?
and Case three:
```javascript
{
expandAndCollapse: true,
nodeClick: 'link'
}
```
link to target or expand node, even both.
Or other solutions, remove the interaction of `expandAndCollapse `, it only controls nodes on init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-993124301
This issue is labeled with `difficulty: easy`.
@tomatosqq Would you like to debug it by yourself? This is a quicker way to get your problem fixed. Or you may wait for the community to fix.
Please have a look at [How to debug ECharts](https://github.com/apache/echarts/blob/master/CONTRIBUTING.md#how-to-debug-echarts) if you'd like to give a try. 🤓
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] fuchunhui edited a comment on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
fuchunhui edited a comment on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1048691992
> It should provide a `nodeClick` option with values of `false | 'expand' | 'link'` similar to [treemap series](https://echarts.apache.org/en/option.html#series-treemap.nodeClick).
some questions:
1. add `nodeClick` or update `expandAndCollapse`?
2. if used `expandAndCollapse`, renamed to `nodeClick`?
3. if used `expandAndCollapse`, how to ensure api compatibility, where can i refer to?
```
{
expandAndCollapse: true
}
```
as same as
```
{
expandAndCollapse: 'expand'
}
```
@Ovilia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] fuchunhui commented on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
fuchunhui commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1065909532
I thought about it carefully, but I still have a little doubt.
`expandAndCollapse ` is not only initialization, but also interactive behavior. It supports collapses and expands interaction of nodes. What I'm confused about now is how to ensure the coexistence of the two and who has the higher priority.
Case one:
```javascript
{
expandAndCollapse: true,
nodeClick: false
}
```
Click the node, what will happen.
Case two:
```javascript
{
expandAndCollapse: false,
nodeClick: true
}
```
What 's the result?
and Case three:
```javascript
{
expandAndCollapse: true,
nodeClick: 'link'
}
link to target or expand node, even both.
Or other solutions, remove the interaction of `expandAndCollapse `, it only controls nodes on init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1067531968
I think the existing `expandAndCollapse` didn't design well. The name is confusing and it's couples the initialization state and interactive behavior as @fuchunhui says.
I will suggest we deprecate this option and providing two separate configs `nodeClick` and `collapsible / expandable`. If these two is not given, we still use `expandAndCollapse` to avoid breaking any the existing app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] tomatosqq commented on issue #16169: echarts tree click on the label to trigger a click event and get Node information but not to close the child. when Click on the symbol to close it
Posted by GitBox <gi...@apache.org>.
tomatosqq commented on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-985979903
echarts tree click on the label to trigger a click event but not to close the child. Click on the symbol to close it. Can it be separated? Because there is a function to get the detailed display pop-up window when you click on the label, but don’t close the secondary tree
> Could you please describe the feature in short in your title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on issue #16169: [Feature] tree series nodeClick support clicking
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #16169:
URL: https://github.com/apache/echarts/issues/16169#issuecomment-1067531968
I think the existing `expandAndCollapse` didn't design well. The name is confusing and it's couples the initialization state and interactive behavior as @fuchunhui says.
I will suggest we deprecate this option and providing two separate configs `nodeClick` and `collapsible / expandable`. If these two is not given, we still use `expandAndCollapse` but give a deprecation warning to avoid breaking any the existing app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org