You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/20 21:37:19 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24466: chore(dao): Condense delete/bulk-delete
codecov[bot] commented on PR #24466:
URL: https://github.com/apache/superset/pull/24466#issuecomment-1599597448
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24466](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f7582fc) into [master](https://app.codecov.io/gh/apache/superset/commit/c3b5d72f2b078eff4ff21213085f0d4ad6d282e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c3b5d72) will **decrease** coverage by `10.67%`.
> The diff coverage is `65.41%`.
> :exclamation: Current head f7582fc differs from pull request most recent head 0d219ef. Consider uploading reports for the commit 0d219ef to get more accurate results
```diff
@@ Coverage Diff @@
## master #24466 +/- ##
===========================================
- Coverage 68.85% 58.18% -10.67%
===========================================
Files 1901 1901
Lines 73969 73956 -13
Branches 8119 8116 -3
===========================================
- Hits 50931 43031 -7900
- Misses 20927 28814 +7887
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.96% <60.80%> (?)` | |
| postgres | `?` | |
| presto | `53.86% <57.60%> (?)` | |
| python | `60.92% <68.00%> (-22.21%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.66% <61.60%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ckages/superset-ui-chart-controls/src/constants.ts](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...erset-ui-chart-controls/src/utils/columnChoices.ts](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3V0aWxzL2NvbHVtbkNob2ljZXMudHM=) | `100.00% <ø> (ø)` | |
| [...packages/superset-ui-core/src/query/types/Query.ts](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvcXVlcnkvdHlwZXMvUXVlcnkudHM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `69.16% <ø> (-0.27%)` | :arrow_down: |
| [...d/src/SqlLab/components/SaveDatasetModal/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwvaW5kZXgudHN4) | `50.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/fixtures.ts](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9maXh0dXJlcy50cw==) | `100.00% <ø> (ø)` | |
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `35.08% <ø> (+0.30%)` | :arrow_up: |
| [...otation\_layers/annotations/commands/bulk\_delete.py](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `50.00% <0.00%> (-37.50%)` | :arrow_down: |
| [superset/annotation\_layers/commands/bulk\_delete.py](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [superset/charts/commands/bulk\_delete.py](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | `44.44% <0.00%> (-46.99%)` | :arrow_down: |
| ... and [37 more](https://app.codecov.io/gh/apache/superset/pull/24466?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [265 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24466/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org