You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/12 21:09:26 UTC
[GitHub] [hive] viirya opened a new pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
viirya opened a new pull request #1397:
URL: https://github.com/apache/hive/pull/1397
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to shade Guava from hive-exec in Hive branch-2. This is basically for triggering test for #1356.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When trying to upgrade Guava in Spark, found the following error. A Guava method became package-private since Guava version 20. So there is incompatibility with Guava versions > 19.0.
```
sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.IllegalAccessError: tried to access method com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; from class org.apache.hadoop.hive.ql.exec.FetchOperator
at org.apache.hadoop.hive.ql.exec.FetchOperator.<init>(FetchOperator.java:108)
at org.apache.hadoop.hive.ql.exec.FetchTask.initialize(FetchTask.java:87)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:541)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1457)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1237)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1227)
```
This is a problem for downstream clients. Hive project noticed that problem too in [HIVE-22126](https://issues.apache.org/jira/browse/HIVE-22126), however that only targets 4.0.0. It'd be nicer if we can also shade Guava from current Hive versions, e.g. Hive 2.3 line.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Guava will be shaded from hive-exec.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Built Hive locally and checked jar content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-674569123
@sunchao Can you reproduce the test failure locally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-674440199
I tried to run failed tests locally.
```
mvn clean -Dtest=org.apache.hive.hcatalog.pig.TestParquetHCatStorer test
```
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
Running org.apache.hive.hcatalog.pig.TestParquetHCatStorer
Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 106.145 sec - in org.apache.hive.hcatalog.pig.TestParquetHCatStorer
Results :
Tests run: 27, Failures: 0, Errors: 0, Skipped: 0
```
```
mvn clean -Dtest=org.apache.hive.hcatalog.mapreduce.TestHCatDynamicPartitioned test
```
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
Running org.apache.hive.hcatalog.mapreduce.TestHCatDynamicPartitioned
Tests run: 14, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 143.976 sec - in org.apache.hive.hcatalog.mapreduce.TestHCatDynamicPartitioned
Results :
Tests run: 14, Failures: 0, Errors: 0, Skipped: 4
```
But I cannot reproduce the test failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-673159411
@viirya it probably means those tests were already failing previously. However I was not able to find a history for this. According to this [comment](https://issues.apache.org/jira/browse/HIVE-21790?focusedCommentId=17134282&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17134282), it seems many tests were failing after we enabled CI for branch-2.
cc @belugabehr - wonder if you have any info on this. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-674242875
Any idea about which tests I should take a look at?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao merged pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao merged pull request #1397:
URL: https://github.com/apache/hive/pull/1397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-673129939
@viirya seems there is no new testing failing which is good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-674677369
> @sunchao Can you reproduce the test failure locally?
NO I took two failed tests and can't reproduce them locally, with and without your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-674701692
Yeah, however I think this PR is trivial enough and I don't see the tests are related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-673112654
cc @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-673145461
@sunchao But I saw some test failures?
`There are 0 new tests failing, 636 existing failing and 231 skipped.`
What existing failing means?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sunchao commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-674415824
@viirya I see most of these test failures are related to Calcite so seems not related, and they were failing previously. Maybe we can trigger the tests again by force push. Also it'd be great if we can verify locally by selecting a few test before and after the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] viirya commented on pull request #1397: HIVE-23980: Shade Guava from hive-exec in Hive branch-2
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #1397:
URL: https://github.com/apache/hive/pull/1397#issuecomment-674680831
> > @sunchao Can you reproduce the test failure locally?
>
> NO I took two failed tests and can't reproduce them locally, with and without your PR.
Hm, it makes harder to debug...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org