You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "Chenjp (via GitHub)" <gi...@apache.org> on 2025/01/15 08:08:27 UTC
[PR] Webdav special path handling fix [tomcat]
Chenjp opened a new pull request, #807:
URL: https://github.com/apache/tomcat/pull/807
1. fix: "/web-information.xml" is not a special path.
2. method name refactoring: from isSpecialPath to checkSpecialPath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Webdav special path handling fix [tomcat]
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher closed pull request #807: Webdav special path handling fix
URL: https://github.com/apache/tomcat/pull/807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Webdav special path handling fix [tomcat]
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #807:
URL: https://github.com/apache/tomcat/pull/807#issuecomment-2592078702
Ok, the check should be similar to what it is in StandardContextValve. I won't rename the method however, and I see a few things to cleanup as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Webdav special path handling fix [tomcat]
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #807:
URL: https://github.com/apache/tomcat/pull/807#issuecomment-2592187806
I did not pick up the test since it doesn't add much.
Also because of:
File appDir = new File(getBuildDirectory(), "webapps" + contextPath);
try (FileWriter fw = new FileWriter(new File(appDir, "WEB-INFORMATION.xml"))) {
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Webdav special path handling fix [tomcat]
Posted by "Chenjp (via GitHub)" <gi...@apache.org>.
Chenjp commented on PR #807:
URL: https://github.com/apache/tomcat/pull/807#issuecomment-2592561309
> I see a few things to cleanup as well.
+1.
rename method is better.
about testcase: pls try to cover allowSpecialPaths and nonroot webdav path. Current testcase is not enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org