[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26562: Remove never-worked githubPush trigger

["ahmedabu98 (via GitHub)" <gi...@apache.org>]

ahmedabu98 commented on code in PR #26562:
URL: https://github.com/apache/beam/pull/26562#discussion_r1187281880


##########
.test-infra/jenkins/PostcommitJobBuilder.groovy:
##########
@@ -57,8 +60,15 @@ class PostcommitJobBuilder {
   }
 
   void defineAutoPostCommitJob(name) {
+    // default build schedule
+    String buildSchedule = 'H H/6 * * *'
+    try {
+      buildSchedule = scope.getProperty('buildSchedule')
+    } catch (MissingPropertyException ignored) {
+      // do nothing
+    }

Review Comment:
   instead of try catch block, can do something like 
   ```suggestion
       String buildSchedule = scope.hasProperty('buildSchedule')?.getProperty(scope) ?: 'H H/6 * * *'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org