You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/02/07 03:19:46 UTC

[kudu-CR] WIP: enable kerberos support in CSD

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5921

to review the following change.

Change subject: WIP: enable kerberos support in CSD
......................................................................

WIP: enable kerberos support in CSD

Change-Id: Iea2d36b7a0da38cd6ddd646a32f52517cabeb4a6
---
M java/kudu-csd/src/descriptor/service.sdl
1 file changed, 43 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/5921/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea2d36b7a0da38cd6ddd646a32f52517cabeb4a6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] WIP: enable kerberos support in CSD

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: WIP: enable kerberos support in CSD
......................................................................


Patch Set 1:

I think we should hold off on committing this until we review all of the new security flags comprehensively.

-- 
To view, visit http://gerrit.cloudera.org:8080/5921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea2d36b7a0da38cd6ddd646a32f52517cabeb4a6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] WIP: enable kerberos support in CSD

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: WIP: enable kerberos support in CSD
......................................................................


Patch Set 1:

yea, that's fine. It's useful to have up on gerrit, though -- makes it much easier to test in a kerberized environment, even if you have to do a local build.

-- 
To view, visit http://gerrit.cloudera.org:8080/5921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea2d36b7a0da38cd6ddd646a32f52517cabeb4a6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] WIP: enable kerberos support in CSD

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change.

Change subject: WIP: enable kerberos support in CSD
......................................................................


Abandoned

The CSD has been removed from the kudu repo, so closing this review

-- 
To view, visit http://gerrit.cloudera.org:8080/5921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iea2d36b7a0da38cd6ddd646a32f52517cabeb4a6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>