You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/30 18:57:08 UTC
[GitHub] [maven-surefire] SimonBaars opened a new pull request, #576: [NO-JIRA] Refactor integration tests module
SimonBaars opened a new pull request, #576:
URL: https://github.com/apache/maven-surefire/pull/576
I recently picked up a task to remove the `forkMode` parameter (#575), and found parts of the code hard to work with because of redundant constructs in the code:
- When a method has `throws Exception`, I expect the method to throw the wildest things if we have to use the base Exception class in the method declaration. Oftentimes, there were no checked exceptions at all. I removed the declarations where they were not needed and refactored some others where `Exception` was too much to be thrown.
- There was some commented code dating back many years ago, which is unlikely to be used again. Better to remove it and reduce cognitive load.
- Some methods were unused.
- A few other small issues
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #576: [NO-JIRA] Refactor integration tests module
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #576:
URL: https://github.com/apache/maven-surefire/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #576: [NO-JIRA] Refactor integration tests module
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #576:
URL: https://github.com/apache/maven-surefire/pull/576#issuecomment-1362595584
@SimonBaars can you resolve conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #576: [NO-JIRA] Refactor integration tests module
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #576:
URL: https://github.com/apache/maven-surefire/pull/576#issuecomment-1364296910
@SimonBaars thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] SimonBaars commented on pull request #576: [NO-JIRA] Refactor integration tests module
Posted by GitBox <gi...@apache.org>.
SimonBaars commented on PR #576:
URL: https://github.com/apache/maven-surefire/pull/576#issuecomment-1363759581
> @SimonBaars can you resolve conflicts?
On it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org