[hbase] branch branch-2.4 updated: HBASE-25570 On largish cluster, "CleanerChore: Could not delete dir..." makes master log unreadable (#2949)

[st...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new 8658650  HBASE-25570 On largish cluster, "CleanerChore: Could not delete dir..." makes master log unreadable (#2949)
8658650 is described below

commit 86586508230d23540e4094106dc4433f2fe58b51
Author: Michael Stack <sa...@users.noreply.github.com>
AuthorDate: Thu Mar 11 21:35:24 2021 -0800

    HBASE-25570 On largish cluster, "CleanerChore: Could not delete dir..." makes master log unreadable (#2949)
    
    Turn down the amount we log. If you want to see the full exception
    enable TRACE-level logging.
    
    Signed-off-by: Duo Zhang <zh...@apache.org>
    Signed-off-by: shahrs87
---
 .../org/apache/hadoop/hbase/master/cleaner/CleanerChore.java  | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index 9416e5a..a8f6798 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -468,9 +468,14 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
       LOG.debug("Couldn't delete '{}' yet because it isn't empty w/exception.", dir, exception);
       deleted = false;
     } catch (IOException ioe) {
-      LOG.info("Could not delete {} under {}. might be transient; we'll retry. if it keeps "
-          + "happening, use following exception when asking on mailing list.",
-        type, dir, ioe);
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Could not delete {} under {}; will retry. If it keeps happening, " +
+            "quote the exception when asking on mailing list.", type, dir, ioe);
+      } else {
+        LOG.info("Could not delete {} under {} because {}; will retry. If it  keeps happening, enable" +
+            "TRACE-level logging and quote the exception when asking on mailing list.",
+            type, dir, ioe.getMessage());
+      }
       deleted = false;
     } catch (Exception e) {
       LOG.info("unexpected exception: ", e);