You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2016/03/09 22:44:13 UTC
Review Request 44594: Fix ordering of Alter table calls which could
result in Region Close issue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44594/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
Bugs: AMBARI-15361
https://issues.apache.org/jira/browse/AMBARI-15361
Repository: ambari
Description
-------
Two Alter table calls one of TTL and the other for setting the Region policies could result in a possible race condition on HBase side.
Here is some details:
The assignment operation on the region in question ({{2e13a2d264c50e27c32cd4d3cad6ebca}}) further indicates possible network partition - the region is CLOSED and OFFLINED successfully, and trying to OPEN again, but it found conflict information from zk node (the zk node had a stale information and still thought that it is still in the CLOSING state, which is not true based on the log) - the assignment succeeds, but updating the assignment information to zk failed due to incorrect version in the zk node.
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java f460292
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 4afb722
Diff: https://reviews.apache.org/r/44594/diff/
Testing
-------
Unit tests passed. No funtional change.
Thanks,
Sid Wagle
Re: Review Request 44594: Fix ordering of Alter table calls which
could result in Region Close issue
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44594/#review122815
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On March 9, 2016, 9:44 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44594/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 9:44 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15361
> https://issues.apache.org/jira/browse/AMBARI-15361
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Alter table calls one of TTL and the other for setting the Region policies could result in a possible race condition on HBase side.
>
> Here is some details:
> The assignment operation on the region in question ({{2e13a2d264c50e27c32cd4d3cad6ebca}}) further indicates possible network partition - the region is CLOSED and OFFLINED successfully, and trying to OPEN again, but it found conflict information from zk node (the zk node had a stale information and still thought that it is still in the CLOSING state, which is not true based on the log) - the assignment succeeds, but updating the assignment information to zk failed due to incorrect version in the zk node.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java f460292
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 4afb722
>
> Diff: https://reviews.apache.org/r/44594/diff/
>
>
> Testing
> -------
>
> Unit tests passed. No funtional change.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 44594: Fix ordering of Alter table calls which
could result in Region Close issue
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44594/#review122842
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On March 10, 2016, 12:34 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44594/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:34 a.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15361
> https://issues.apache.org/jira/browse/AMBARI-15361
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Alter table calls one of TTL and the other for setting the Region policies could result in a possible race condition on HBase side.
>
> Here is some details:
> The assignment operation on the region in question ({{2e13a2d264c50e27c32cd4d3cad6ebca}}) further indicates possible network partition - the region is CLOSED and OFFLINED successfully, and trying to OPEN again, but it found conflict information from zk node (the zk node had a stale information and still thought that it is still in the CLOSING state, which is not true based on the log) - the assignment succeeds, but updating the assignment information to zk failed due to incorrect version in the zk node.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 465fe95
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 48be4ee
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java e3e037a
>
> Diff: https://reviews.apache.org/r/44594/diff/
>
>
> Testing
> -------
>
> Unit tests passed. No funtional change.
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 44594: Fix ordering of Alter table calls which
could result in Region Close issue
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44594/
-----------------------------------------------------------
(Updated March 10, 2016, 12:34 a.m.)
Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
Changes
-------
Changed.
Bugs: AMBARI-15361
https://issues.apache.org/jira/browse/AMBARI-15361
Repository: ambari
Description
-------
Two Alter table calls one of TTL and the other for setting the Region policies could result in a possible race condition on HBase side.
Here is some details:
The assignment operation on the region in question ({{2e13a2d264c50e27c32cd4d3cad6ebca}}) further indicates possible network partition - the region is CLOSED and OFFLINED successfully, and trying to OPEN again, but it found conflict information from zk node (the zk node had a stale information and still thought that it is still in the CLOSING state, which is not true based on the log) - the assignment succeeds, but updating the assignment information to zk failed due to incorrect version in the zk node.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 465fe95
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 48be4ee
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java e3e037a
Diff: https://reviews.apache.org/r/44594/diff/
Testing
-------
Unit tests passed. No funtional change.
Thanks,
Sid Wagle
Re: Review Request 44594: Fix ordering of Alter table calls which
could result in Region Close issue
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44594/
-----------------------------------------------------------
(Updated March 10, 2016, 12:17 a.m.)
Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
Changes
-------
Modifications:
- Moved ALTER TTL calls to the HBaseAdmin call for updating policies
- Modified unit test to verify changes.
Bugs: AMBARI-15361
https://issues.apache.org/jira/browse/AMBARI-15361
Repository: ambari
Description
-------
Two Alter table calls one of TTL and the other for setting the Region policies could result in a possible race condition on HBase side.
Here is some details:
The assignment operation on the region in question ({{2e13a2d264c50e27c32cd4d3cad6ebca}}) further indicates possible network partition - the region is CLOSED and OFFLINED successfully, and trying to OPEN again, but it found conflict information from zk node (the zk node had a stale information and still thought that it is still in the CLOSING state, which is not true based on the log) - the assignment succeeds, but updating the assignment information to zk failed due to incorrect version in the zk node.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 465fe95
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 48be4ee
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java e3e037a
Diff: https://reviews.apache.org/r/44594/diff/
Testing
-------
Unit tests passed. No funtional change.
Thanks,
Sid Wagle