You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2012/10/09 23:38:02 UTC
[jira] [Created] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Devaraj Das created HBASE-6966:
----------------------------------
Summary: "Compressed RPCs for HBase" (HBASE-5355) port to trunk
Key: HBASE-6966
URL: https://issues.apache.org/jira/browse/HBASE-6966
Project: HBase
Issue Type: Improvement
Components: IPC/RPC
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6966:
-------------------------------
Attachment: 6966-1.patch
A pass on the port. This patch looks simpler than the original one mostly because the patch doesn't handle backward compatibility.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487441#comment-13487441 ]
Hadoop QA commented on HBASE-6966:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12551466/6966-v1.1.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3193//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3193//console
This message is automatically generated.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6966:
-------------------------------
Attachment: 6966-v1.1.txt
Patch that addresses [~enis]'s comment on the exception handling.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481478#comment-13481478 ]
Devaraj Das commented on HBASE-6966:
------------------------------------
[~enis] I'll take a look at incorporating your comment#1. I agree that comment#2 could be handled as a follow up jira.
[~lhofhansl] I was thinking of running a table operation for 1000 times or something, and checking the time taken with/without patch. Makes sense? Anything else?
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492185#comment-13492185 ]
Hadoop QA commented on HBASE-6966:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552427/6966-v1.2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 87 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 15 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3248//console
This message is automatically generated.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v1.2.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489707#comment-13489707 ]
Enis Soztutar commented on HBASE-6966:
--------------------------------------
Sorry Devaraj, I've just committed HBASE-7063, you may have to rebase this.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507031#comment-13507031 ]
Devaraj Das commented on HBASE-6966:
------------------------------------
Sorry for being silent on this one. The update on this one is when I tried this benchmark, it seemed like there is some bug which shows up sometimes and makes the benchmark application really slow (RPCs become really slow). I will debug it sometime..
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v1.2.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474657#comment-13474657 ]
Hadoop QA commented on HBASE-6966:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12548821/6966-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 81 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestCheckTestClasses
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3037//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3037//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3037//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3037//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3037//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3037//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3037//console
This message is automatically generated.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480508#comment-13480508 ]
Enis Soztutar commented on HBASE-6966:
--------------------------------------
Patch looks good. Two questions:
1. What happens when the server does not support a compression set from the client. I guess we might want to throw DoNotRetryIOException, or a specific exception to let the client know that it should not try to use the same compression.
2. we are introducing dependency to hfile.io in rpc layer. Ideally, we should refactor hfile.io to o.a.h.h.io. We can do it later in another issue I guess.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498224#comment-13498224 ]
Andrew Purtell commented on HBASE-6966:
---------------------------------------
+1 on providing benchmarks.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v1.2.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6966:
-------------------------------
Attachment: 6966-v1.2.txt
Updated to the latest trunk. Still need to run benchmarks..
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v1.2.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493427#comment-13493427 ]
Hadoop QA commented on HBASE-6966:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552427/6966-v1.2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 87 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 15 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3267//console
This message is automatically generated.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v1.1.txt, 6966-v1.2.txt, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6966:
--------------------------
Attachment: 6966-v2.txt
Patch v2 adds license header to TestRPCCompression, along with test category.
Javadoc for a few new methods is missing.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6966:
-------------------------------
Status: Patch Available (was: Open)
Getting it reviewed by hadoopqa first.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480622#comment-13480622 ]
Lars Hofhansl commented on HBASE-6966:
--------------------------------------
Patch looks good. I'm fine with having this in 0.96 only (especially with the complication of the SecureRpcEngine in 0.94).
Still would like some quick and dirty (does not have to be anything fancy) latency numbers, so that we can set expectations.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6966) "Compressed RPCs for HBase"
(HBASE-5355) port to trunk
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475538#comment-13475538 ]
Hadoop QA commented on HBASE-6966:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12549000/6966-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 81 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
org.apache.hadoop.hbase.replication.TestMasterReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3049//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3049//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3049//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3049//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3049//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3049//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3049//console
This message is automatically generated.
> "Compressed RPCs for HBase" (HBASE-5355) port to trunk
> ------------------------------------------------------
>
> Key: HBASE-6966
> URL: https://issues.apache.org/jira/browse/HBASE-6966
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6966-1.patch, 6966-v2.txt
>
>
> This jira will address the port of the compressed RPC implementation to trunk. I am expecting the patch to be significantly different due to the PB stuff in trunk, and hence filed a separate jira.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira