You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2005/01/24 22:45:38 UTC

svn commit: r126319 - /spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm

Author: jm
Date: Mon Jan 24 13:45:37 2005
New Revision: 126319

URL: http://svn.apache.org/viewcvs?view=rev&rev=126319
Log:
work around annoying undef warnings from new SIGCHLD code
Modified:
   spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm
Url: http://svn.apache.org/viewcvs/spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm?view=diff&rev=126319&p1=spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm&r1=126318&p2=spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm&r2=126319
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm	(original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Dns.pm	Mon Jan 24 13:45:37 2005
@@ -1169,7 +1169,16 @@
   dbg("info: leaving helper-app run mode");
   $/ = $self->{old_slash};
   %ENV = %{$self->{old_env}};
-  $SIG{CHLD} = $self->{old_sigchld_handler};
+
+  if (defined $self->{old_sigchld_handler}) {
+    $SIG{CHLD} = $self->{old_sigchld_handler};
+  } else {
+    # if SIGCHLD has never been explicitly set, it's returned as undef.
+    # however, when *setting* SIGCHLD, using undef(%) or assigning to an
+    # undef value produces annoying 'Use of uninitialized value in scalar
+    # assignment' warnings.  That's silly.  workaround:
+    $SIG{CHLD} = 'DEFAULT';
+  }
 }
 
 # note: this must be called before leave_helper_run_mode() is called,