You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/25 08:55:24 UTC

[GitHub] [dolphinscheduler] DarkAssassinator opened a new issue, #12133: [Bug] [Dao] Some classes overrides equals(Object), but does not override hashCode()

DarkAssassinator opened a new issue, #12133:
URL: https://github.com/apache/dolphinscheduler/issues/12133

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   `SpotBugs` found that some classes overrides `equals(Object)`, but does not override `hashCode()`, and inherits the implementation of hashCode() from java.lang.Object (which returns the identity hash code, an arbitrary value assigned to the object by the VM).  Therefore, the class is very likely to violate the invariant that equal objects must have equal hashcodes.
   + TaskDefinition
   + ProcessData
   + ProcessDefinition
   + ProcessDefinitionLog
   
   ### What you expected to happen
   
   Class can overwrite `euqal()` and `hashCode()` at the same time
   
   ### How to reproduce
   
   just review the code
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] DarkAssassinator closed issue #12133: [Bug] [Dao] Some classes overrides equals(Object), but does not override hashCode()

Posted by GitBox <gi...@apache.org>.
DarkAssassinator closed issue #12133: [Bug] [Dao] Some classes overrides equals(Object), but does not override hashCode()
URL: https://github.com/apache/dolphinscheduler/issues/12133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #12133: [Bug] [Dao] Some classes overrides equals(Object), but does not override hashCode()

Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on issue #12133:
URL: https://github.com/apache/dolphinscheduler/issues/12133#issuecomment-1279911903

   close issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12133: [Bug] [Dao] Some classes overrides equals(Object), but does not override hashCode()

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12133:
URL: https://github.com/apache/dolphinscheduler/issues/12133#issuecomment-1257150014

   Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org