You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:54:27 UTC

Review Request 61291: Imported `glog` library.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61291/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Imported `glog` library.


Diffs
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 


Diff: https://reviews.apache.org/r/61291/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer

Re: Review Request 61291: Imported `glog` library.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61291/
-----------------------------------------------------------

(Updated Aug. 11, 2017, 4:20 p.m.)


Review request for mesos.


Changes
-------

Disallow linking to static library. Also brought over `GTEST_CONFIG=no` from Autotools.

Note that when we update Glog, and build with CMake, we'll be able to link to shared or static as needed.


Repository: mesos


Description
-------

Review: https://reviews.apache.org/r/61291


Diffs (updated)
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 


Diff: https://reviews.apache.org/r/61291/diff/3/

Changes: https://reviews.apache.org/r/61291/diff/2-3/


Testing
-------


Thanks,

Andrew Schwartzmeyer

Re: Review Request 61291: Imported `glog` library.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61291/
-----------------------------------------------------------

(Updated Aug. 8, 2017, 5:54 p.m.)


Review request for mesos.


Changes
-------

Moved glog compile definitions to here.


Repository: mesos


Description (updated)
-------

Review: https://reviews.apache.org/r/61291


Diffs (updated)
-----

  3rdparty/CMakeLists.txt f4feaf90b4750338cfa2127524a5e6556a86d063 


Diff: https://reviews.apache.org/r/61291/diff/2/

Changes: https://reviews.apache.org/r/61291/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer