You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "georgthegreat (via GitHub)" <gi...@apache.org> on 2025/01/13 14:11:31 UTC
[PR] Fix undefined behavior [orc]
georgthegreat opened a new pull request, #2112:
URL: https://github.com/apache/orc/pull/2112
### What changes were proposed in this pull request?
Unaligned reads are UB in C++, memcpy-ing zero bytes is UB either.
### How was this patch tested?
Internal UBsan report was used to detect and fix this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2588616700
Perhaps we should enable UBSAN together with the ASAN CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: Fix undefined behavior [orc]
Posted by "georgthegreat (via GitHub)" <gi...@apache.org>.
georgthegreat commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2587611011
@wgtmac, I have filed https://issues.apache.org/jira/browse/ORC-1834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2597265610
I backported this to branch-2.1 and reassigned the milestone to `2.1.1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed pull request #2112: ORC-1834: [C++] Fix undefined behavior
URL: https://github.com/apache/orc/pull/2112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2597269551
My bad. I remove it from `branch-2.1` because it causes CI failures.
<img width="402" alt="Screenshot 2025-01-16 at 17 53 38" src="https://github.com/user-attachments/assets/476b8ec3-6107-4a49-9e93-013623d6e29e" />
In this case, we need a backporting PR. Could you make another PR to branch-2.1, @georgthegreat ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix undefined behavior [orc]
Posted by "georgthegreat (via GitHub)" <gi...@apache.org>.
georgthegreat commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2587213274
The form suggest filing a JIRA issue, but
> Public signup for this instance is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: Fix undefined behavior [orc]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2588615049
Thanks @dongjoon-hyun! The linter CI is green after rebased: https://github.com/apache/orc/actions/runs/12759485419/job/35563347180?pr=2112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2597264404
Got it, @georgthegreat .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2596469793
Shall we backport this bug fix to branch-2.1 ? Or, Apache ORC 2.2 (2026-01-15) is enough for delivery schedule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "georgthegreat (via GitHub)" <gi...@apache.org>.
georgthegreat commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2596636908
For us it would be better to have this backported to 2.1 and have a release tagged.
Thus we could remove the patch from the internal version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1834: [C++] Fix undefined behavior [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2597266032
Thank you, @georgthegreat and @wgtmac .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix undefined behavior [orc]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #2112:
URL: https://github.com/apache/orc/pull/2112#issuecomment-2587351216
Thanks for fixing this!
> Public signup for this instance is disabled.
You may request an account at https://selfserve.apache.org/jira-account.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org