[GitHub] [spark] dongjoon-hyun commented on issue #25388: [SPARK-28656][SQL] Support `millennium`, `century` and `decade` at `extract()`

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on issue #25388: [SPARK-28656][SQL] Support `millennium`, `century` and `decade` at `extract()`
URL: https://github.com/apache/spark/pull/25388#issuecomment-519686831
 
 
   Hi, @MaxGekk .
   1. Supporting `Extract` seems to be enough for PostgreSQL feature parity. 
   2. Supporting the followings are easy, but I'm not sure about these. In general, I'd recommend not to register as functions. PMC may have different opinions.
   ```
   spark-sql> SELECT MILLENNIUM('2019-08-08');
   3
   spark-sql> SELECT CENTURY('2019-08-08');
   21
   spark-sql> SELECT DECADE('2019-08-08');
   201
   ```
   
   How do you think about (2) which adds these new functions , @gatorsmile and @cloud-fan ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org