You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/12/18 18:57:18 UTC
[GitHub] brodybits commented on a change in pull request #478: Apply shell
interaction approaches consistently
brodybits commented on a change in pull request #478: Apply shell interaction approaches consistently
URL: https://github.com/apache/cordova-ios/pull/478#discussion_r242662913
##########
File path: bin/templates/scripts/cordova/lib/run.js
##########
@@ -87,15 +88,13 @@ module.exports.run = function (runOptions) {
var payloadFolder = path.join(buildOutputDir, 'Payload');
// delete the existing platform/ios/build/device/appname.app
- return spawn('rm', [ '-rf', appFile ], buildOutputDir)
- .then(function () {
- // move the platform/ios/build/device/Payload/appname.app to parent
- return spawn('mv', [ '-f', appFileInflated, buildOutputDir ], buildOutputDir);
- })
- .then(function () {
- // delete the platform/ios/build/device/Payload folder
- return spawn('rm', [ '-rf', payloadFolder ], buildOutputDir);
- });
+ shell.rm('-rf', appFile);
Review comment:
Just a quick comment that we have taken efforts to use `fs-extra` instead of `shelljs` in some other parts of the Cordova project. I would favor we do something similar in `cordova-ios` someday in the future (should not block Cordova 9 release).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org