You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by masaru tsuchiyama <m....@gmail.com> on 2007/02/25 13:34:31 UTC
Re: Fwd: [PATCH] Make win_tests.py work out-of-the-box
Hello
> The only problem with in-tree tests is that we don't create the
> 'subversion\tests\cmdline' directory. This is trivial to fix:
>
> Index: win-tests.py
> ===================================================================
> --- win-tests.py (revision 22924)
> +++ win-tests.py (working copy)
> @@ -447,13 +447,14 @@
> os.chdir(abs_objdir)
> baton = copied_execs
> os.path.walk('subversion', copy_execs, baton)
> - create_target_dir(CMDLINE_TEST_SCRIPT_NATIVE_PATH)
> except:
> os.chdir(old_cwd)
> raise
> else:
> os.chdir(old_cwd)
>
> +create_target_dir(CMDLINE_TEST_SCRIPT_NATIVE_PATH)
> +
> # Ensure the tests directory is correctly cased
> abs_builddir = fix_case(abs_builddir)
I also see that Vlad's patch is valid for the errors in getopt_tests.py.
Does anybody commit the patch?
Masaru
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Fwd: [PATCH] Make win_tests.py work out-of-the-box
Posted by Vlad Georgescu <vg...@gmail.com>.
masaru tsuchiyama wrote:
> Hello
>
>> The only problem with in-tree tests is that we don't create the
>> 'subversion\tests\cmdline' directory. This is trivial to fix:
>>
>> Index: win-tests.py
>> ===================================================================
>> --- win-tests.py (revision 22924)
>> +++ win-tests.py (working copy)
>> @@ -447,13 +447,14 @@
>> os.chdir(abs_objdir)
>> baton = copied_execs
>> os.path.walk('subversion', copy_execs, baton)
>> - create_target_dir(CMDLINE_TEST_SCRIPT_NATIVE_PATH)
>> except:
>> os.chdir(old_cwd)
>> raise
>> else:
>> os.chdir(old_cwd)
>>
>> +create_target_dir(CMDLINE_TEST_SCRIPT_NATIVE_PATH)
>> +
>> # Ensure the tests directory is correctly cased
>> abs_builddir = fix_case(abs_builddir)
>
> I also see that Vlad's patch is valid for the errors in getopt_tests.py.
> Does anybody commit the patch?
>
I committed this change in r23496, thanks for reminding me!
--
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org