You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2024/10/28 18:25:42 UTC

[PR] NIFI-13941 Fix Maximum Length for DNS Certificate SAN from Proxy Hosts [nifi]

exceptionfactory opened a new pull request, #9462:
URL: https://github.com/apache/nifi/pull/9462

   # Summary
   
   [NIFI-13941](https://issues.apache.org/jira/browse/NIFI-13941) Corrects DNS Subject Alternative Name handling for generated certificates derived from the `nifi.web.proxy.host` property. Recent changes reduced the maximum length to 64 characters, instead of the 255 allowed according to [RFC 1035 Section 2.3.4](https://www.rfc-editor.org/rfc/rfc1035#section-2.3.4). The adjusted regular expression and unit test verify names longer than 64 characters are allowed.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-13941 Fix Maximum Length for DNS Certificate SAN from Proxy Hosts [nifi]

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #9462:
URL: https://github.com/apache/nifi/pull/9462#issuecomment-2442394797

   Thanks @exceptionfactory for updating. I'm a +1 on the changes. Will merge as soon as Github Actions complete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-13941 Fix Maximum Length for DNS Certificate SAN from Proxy Hosts [nifi]

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 merged PR #9462:
URL: https://github.com/apache/nifi/pull/9462


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-13941 Fix Maximum Length for DNS Certificate SAN from Proxy Hosts [nifi]

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on PR #9462:
URL: https://github.com/apache/nifi/pull/9462#issuecomment-2442555230

   Looks like all builds are looking good. +1 merged to main. Thanks again @exceptionfactory 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org