[jira] [Commented] (CASSANDRA-6400) Update unit tests to use latest Partitioner

["Gösta Forsum (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832413#comment-13832413 ] 

Gösta Forsum commented on CASSANDRA-6400:
-----------------------------------------

Why ?

Changing to Murmur3Partitioner casues approx 35 unit tests to fail. 
Examining some of failing unit test reveals that they rely heavily on the fact the ByteOrderedPartitioner is used. 

Changing to Murmur3Partitioner would increase the complexity of these tests.
(For example: StorageProxyTest.testGRR)

there are separate tests for Murmur3Partitioner.

Testing complicated combinations of classes is more a integration test task.
It is better to have simple unit tests testing the parts and then a few integration tests that try likely combinations of them.

just my 2 cents



> Update unit tests to use latest Partitioner
> -------------------------------------------
>
>                 Key: CASSANDRA-6400
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6400
>             Project: Cassandra
>          Issue Type: Test
>          Components: Tests
>            Reporter: Alex Liu
>            Priority: Minor
>
> test/conf/cassandra.yaml uses the out-date ByteOrderedPartitioner, we should update it to Murmur3Partitioner.



--
This message was sent by Atlassian JIRA
(v6.1#6144)