You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org> on 2011/10/31 13:57:32 UTC
[jira] [Commented] (LUCENE-3546) IW#nrtIsCurrent retruns true if
changes are in del queue but not in bufferedDeleteStream yet
[ https://issues.apache.org/jira/browse/LUCENE-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140112#comment-13140112 ]
Michael McCandless commented on LUCENE-3546:
--------------------------------------------
Egads! Nice catch Simon and Yonik. Sorry I didn't think/realize that this change (cutover to IR.openIfChanged) could have been what lead to Solr's TestRTGet failures...
> IW#nrtIsCurrent retruns true if changes are in del queue but not in bufferedDeleteStream yet
> --------------------------------------------------------------------------------------------
>
> Key: LUCENE-3546
> URL: https://issues.apache.org/jira/browse/LUCENE-3546
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
>
> spinnoff from SOLR-2861 - since the delete queue is not necessarily applied entirely on each request there is a chance that there are changes in the delete queue but not yet in buffered deletes. this can prevent NRT readers from reopen when they should... this shows the problematic code:
> {code}
> Index: java/org/apache/lucene/index/IndexWriter.java
> ===================================================================
> --- java/org/apache/lucene/index/IndexWriter.java (revision 1195214)
> +++ java/org/apache/lucene/index/IndexWriter.java (working copy)
> @@ -4074,7 +4074,7 @@
> synchronized boolean nrtIsCurrent(SegmentInfos infos) {
> //System.out.println("IW.nrtIsCurrent " + (infos.version == segmentInfos.version && !docWriter.anyChanges() && !bufferedDeletesStream.any()));
> ensureOpen();
> - return infos.version == segmentInfos.version && !docWriter.anyChanges() && !bufferedDeletesStream.any();
> + return infos.version == segmentInfos.version && !docWriter.anyChanges() && !docWriter.deleteQueue.anyChanges();
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org