[jira] [Commented] (FLINK-6334) Refactoring UDTF interface

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991539#comment-15991539 ] 

ASF GitHub Bot commented on FLINK-6334:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3791#discussion_r114183388
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamCorrelateRule.scala ---
    @@ -59,10 +59,14 @@ class DataStreamCorrelateRule
             case rel: RelSubset =>
               convertToCorrelate(rel.getRelList.get(0), condition)
     
    -        case calc: FlinkLogicalCalc =>
    +        case calc: FlinkLogicalCalc => {
    --- End diff --
    
    We have to add a check that the Calc only filters but does not modify the input attributes (besides renaming fields). Otherwise, we might lose the projection information (e.g., if one of the table functions attributes is changed by an expression).


> Refactoring UDTF interface
> --------------------------
>
>                 Key: FLINK-6334
>                 URL: https://issues.apache.org/jira/browse/FLINK-6334
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> The current UDTF leverages the table.join(expression) interface, which is not a proper interface in terms of semantics. We would like to refactor this to let UDTF use table.join(table) interface. Very briefly,  UDTF's apply method will return a Table Type, so Join(UDTF('a, 'b, ...) as 'c) shall be viewed as join(Table)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)