You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2013/06/04 21:07:20 UTC

[jira] [Updated] (TAP5-2126) TAP5-2063 fix (multi-valued parameters in Link) conflicts with use of ActivationRequestParameter and PageLink.parameters parameter

     [ https://issues.apache.org/jira/browse/TAP5-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2126:
---------------------------------------

    Labels: backport-5.3.8  (was: )
    
> TAP5-2063 fix (multi-valued parameters in Link) conflicts with use of ActivationRequestParameter and PageLink.parameters parameter
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-2126
>                 URL: https://issues.apache.org/jira/browse/TAP5-2126
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.7, 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Blocker
>              Labels: backport-5.3.8
>
> Imagine a page that has an @ActivationRequestParameter with name "page" (this is for a search results page).
> To navigate between pages of the overall result set, the PageLink uses the parameters parameter to set the page:
>     <t:pagelink page="xxx" parameters="{ page: nextPage }"> ...
> In 5.3.6, this would render as:
>    /xxx?page=Y     (where Y was the value of nextPage)
> In 5.3.7 and 5.4, this renders incorrect as:
>    /xxx?page=A&page=B  (where A is the current value of the page field, and B is the value of nextPage)
> End result: unable to navigate to the next page! 
> I believe the fix for this is to introduce a forceAttribute(String,Object) that overrides, rather than merges, the values.  The parameters parameter will force attributes.
> If that is insufficient, applications can create their own custom linking components, which use the Link interface directly, to get exactly what they need. All of the necessary APIs are public.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira