You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2022/11/30 18:34:05 UTC
[tomcat] branch 8.5.x updated (27da40dc81 -> 1f89e6ba32)
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 27da40dc81 Improvements to Japanese translations.
new 0d727f1b77 Update SpotBugs false positives after AsyncFileHandler refactoring
new 1f89e6ba32 Update false positives
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
res/spotbugs/filter-false-positives.xml | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 02/02: Update false positives
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 1f89e6ba32591847c5006678ba47c31328e65e9f
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Nov 30 18:33:56 2022 +0000
Update false positives
---
res/spotbugs/filter-false-positives.xml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index 991374f557..8405047bc8 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -902,6 +902,12 @@
<Method name="process" />
<Bug pattern="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION" />
</Match>
+ <Match>
+ <!-- Method is package private in 9.0.x onwards -->
+ <Class name="org.apache.coyote.AsyncStateMachine" />
+ <Method name="recycle" />
+ <Bug pattern="PS_PUBLIC_SEMAPHORES" />
+ </Match>
<Match>
<!-- readChunk will not be null due to previous call to readBytes() -->
<Class name="org.apache.coyote.http11.filters.ChunkedInputFilter" />
@@ -1295,6 +1301,11 @@
</Or>
<Bug pattern="IS2_INCONSISTENT_SYNC" />
</Match>
+ <Match>
+ <!-- Public API is a design decision of Commons -->
+ <Class name="org.apache.tomcat.dbcp.pool2.impl.SoftReferenceObjectPool" />
+ <Bug pattern="PS_PUBLIC_SEMAPHORES" />
+ </Match>
<Match>
<!-- Return value is ignored but a null result will trigger an exception -->
<Class name="org.apache.tomcat.jdbc.pool.ConnectionPool$ConnectionFuture" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[tomcat] 01/02: Update SpotBugs false positives after AsyncFileHandler refactoring
Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 0d727f1b772c9ca7bda069958512da32b48d4831
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Nov 30 18:17:25 2022 +0000
Update SpotBugs false positives after AsyncFileHandler refactoring
---
res/spotbugs/filter-false-positives.xml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index ece55e90cc..991374f557 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -1130,9 +1130,15 @@
<Method name="scanXMLDeclOrTextDecl"/>
<Bug code="ES"/>
</Match>
+ <Match>
+ <!-- Cast is safe -->
+ <Class name="org.apache.juli.AsyncFileHandler$DropLastPolicy"/>
+ <Method name="rejectedExecution"/>
+ <Bug pattern="BC_UNCONFIRMED_CAST"/>
+ </Match>
<Match>
<!-- Dummy thread -->
- <Class name="org.apache.juli.AsyncFileHandler$LoggerThread"/>
+ <Class name="org.apache.juli.AsyncFileHandler$LoggerExecutorService"/>
<Method name="deregisterHandler"/>
<Bug pattern="DM_USELESS_THREAD"/>
</Match>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org