You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Chuck Deal (JIRA)" <ji...@apache.org> on 2007/03/14 15:46:09 UTC

[jira] Created: (WICKET-388) Change log statement in setObjectStreamFactory

Change log statement in setObjectStreamFactory
----------------------------------------------

                 Key: WICKET-388
                 URL: https://issues.apache.org/jira/browse/WICKET-388
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3
            Reporter: Chuck Deal
            Priority: Trivial


Currently, setObjectStreamFactory looks like this:

public static void setObjectStreamFactory(IObjectStreamFactory objectStreamFactory)
{
	if (objectStreamFactory == null)
	{
		Objects.objectStreamFactory = new IObjectStreamFactory.DefaultObjectStreamFactory();
	}
	else
	{
		Objects.objectStreamFactory = objectStreamFactory;
	}
	log.info("using " + objectStreamFactory + " for creating object streams");
}

In my Application.init(), I tell Wicket to use the WicketObjectStreamFactory with this line:
Objects.setObjectStreamFactory(new wicket.util.io.WicketObjectStreamFactory());	// custom serialization 		

or the default ObjectStreamFactory with this line:
Objects.setObjectStreamFactory(null);	// jdk serialization

However, in my log, when I use the default (null) it outputs:
10:40:42,921  INFO Objects:1156 - using null for creating object streams

instead of showing REAL object that it is using.

I recommend changing this line
	log.info("using " + objectStreamFactory + " for creating object streams");

to this
	log.info("using " + Objects.objectStreamFactory + " for creating object streams");



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-388) Change log statement in Objects#setObjectStreamFactory()

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot resolved WICKET-388.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

Committed, thanks for spotting this!

> Change log statement in Objects#setObjectStreamFactory()
> --------------------------------------------------------
>
>                 Key: WICKET-388
>                 URL: https://issues.apache.org/jira/browse/WICKET-388
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Chuck Deal
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>
> Currently, setObjectStreamFactory looks like this:
> public static void setObjectStreamFactory(IObjectStreamFactory objectStreamFactory)
> {
> 	if (objectStreamFactory == null)
> 	{
> 		Objects.objectStreamFactory = new IObjectStreamFactory.DefaultObjectStreamFactory();
> 	}
> 	else
> 	{
> 		Objects.objectStreamFactory = objectStreamFactory;
> 	}
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> }
> In my Application.init(), I tell Wicket to use the WicketObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(new wicket.util.io.WicketObjectStreamFactory());	// custom serialization 		
> or the default ObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(null);	// jdk serialization
> However, in my log, when I use the default (null) it outputs:
> 10:40:42,921  INFO Objects:1156 - using null for creating object streams
> instead of showing REAL object that it is using.
> I recommend changing this line
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> to this
> 	log.info("using " + Objects.objectStreamFactory + " for creating object streams");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-388) Change log statement in Objects#setObjectStreamFactory()

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot reassigned WICKET-388:
-------------------------------------------

    Assignee: Jean-Baptiste Quenot

> Change log statement in Objects#setObjectStreamFactory()
> --------------------------------------------------------
>
>                 Key: WICKET-388
>                 URL: https://issues.apache.org/jira/browse/WICKET-388
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Chuck Deal
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>
> Currently, setObjectStreamFactory looks like this:
> public static void setObjectStreamFactory(IObjectStreamFactory objectStreamFactory)
> {
> 	if (objectStreamFactory == null)
> 	{
> 		Objects.objectStreamFactory = new IObjectStreamFactory.DefaultObjectStreamFactory();
> 	}
> 	else
> 	{
> 		Objects.objectStreamFactory = objectStreamFactory;
> 	}
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> }
> In my Application.init(), I tell Wicket to use the WicketObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(new wicket.util.io.WicketObjectStreamFactory());	// custom serialization 		
> or the default ObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(null);	// jdk serialization
> However, in my log, when I use the default (null) it outputs:
> 10:40:42,921  INFO Objects:1156 - using null for creating object streams
> instead of showing REAL object that it is using.
> I recommend changing this line
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> to this
> 	log.info("using " + Objects.objectStreamFactory + " for creating object streams");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-388) Change log statement in Objects#setObjectStreamFactory()

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-388:
----------------------------------------

    Summary: Change log statement in Objects#setObjectStreamFactory()  (was: Change log statement in setObjectStreamFactory)

> Change log statement in Objects#setObjectStreamFactory()
> --------------------------------------------------------
>
>                 Key: WICKET-388
>                 URL: https://issues.apache.org/jira/browse/WICKET-388
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Chuck Deal
>            Priority: Trivial
>
> Currently, setObjectStreamFactory looks like this:
> public static void setObjectStreamFactory(IObjectStreamFactory objectStreamFactory)
> {
> 	if (objectStreamFactory == null)
> 	{
> 		Objects.objectStreamFactory = new IObjectStreamFactory.DefaultObjectStreamFactory();
> 	}
> 	else
> 	{
> 		Objects.objectStreamFactory = objectStreamFactory;
> 	}
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> }
> In my Application.init(), I tell Wicket to use the WicketObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(new wicket.util.io.WicketObjectStreamFactory());	// custom serialization 		
> or the default ObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(null);	// jdk serialization
> However, in my log, when I use the default (null) it outputs:
> 10:40:42,921  INFO Objects:1156 - using null for creating object streams
> instead of showing REAL object that it is using.
> I recommend changing this line
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> to this
> 	log.info("using " + Objects.objectStreamFactory + " for creating object streams");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-388) Change log statement in Objects#setObjectStreamFactory()

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-388:
----------------------------------------

    Fix Version/s:     (was: trunk)
                   1.3.0-beta2

> Change log statement in Objects#setObjectStreamFactory()
> --------------------------------------------------------
>
>                 Key: WICKET-388
>                 URL: https://issues.apache.org/jira/browse/WICKET-388
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: trunk
>            Reporter: Chuck Deal
>            Assignee: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3.0-beta2
>
>
> Currently, setObjectStreamFactory looks like this:
> public static void setObjectStreamFactory(IObjectStreamFactory objectStreamFactory)
> {
> 	if (objectStreamFactory == null)
> 	{
> 		Objects.objectStreamFactory = new IObjectStreamFactory.DefaultObjectStreamFactory();
> 	}
> 	else
> 	{
> 		Objects.objectStreamFactory = objectStreamFactory;
> 	}
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> }
> In my Application.init(), I tell Wicket to use the WicketObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(new wicket.util.io.WicketObjectStreamFactory());	// custom serialization 		
> or the default ObjectStreamFactory with this line:
> Objects.setObjectStreamFactory(null);	// jdk serialization
> However, in my log, when I use the default (null) it outputs:
> 10:40:42,921  INFO Objects:1156 - using null for creating object streams
> instead of showing REAL object that it is using.
> I recommend changing this line
> 	log.info("using " + objectStreamFactory + " for creating object streams");
> to this
> 	log.info("using " + Objects.objectStreamFactory + " for creating object streams");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.