You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "amogh-jahagirdar (via GitHub)" <gi...@apache.org> on 2023/10/18 21:36:46 UTC
[PR] AWS, Core: Chore replacing null/empty checks with Apache Commons StringUtils [iceberg]
amogh-jahagirdar opened a new pull request, #8871:
URL: https://github.com/apache/iceberg/pull/8871
Just something I observed when reading the code, there's a few places where we do an explicit null + empty check for Strings. I think it's a bit cleaner to use Apache Commons StringUtils here for null safe checks, reduces boilerplate checks. There's more places throughout the code, but if we agree on this practice here I'll create an issue and others can contribute for addressing the remaining cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core: Chore replacing null/empty checks with Apache Commons StringUtils [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #8871:
URL: https://github.com/apache/iceberg/pull/8871#issuecomment-1769370005
actually nvm, I think this does go against established practices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] AWS, Core: Chore replacing null/empty checks with Apache Commons StringUtils [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar closed pull request #8871: AWS, Core: Chore replacing null/empty checks with Apache Commons StringUtils
URL: https://github.com/apache/iceberg/pull/8871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org