You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/25 01:42:21 UTC
[GitHub] [iotdb] HTHou opened a new pull request, #5655: Draft of Standalone schemafetcher and PartitionFetcher
HTHou opened a new pull request, #5655:
URL: https://github.com/apache/iotdb/pull/5655
## Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#discussion_r857302905
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/config/SetStorageGroupTask.java:
##########
@@ -45,31 +48,39 @@ public SetStorageGroupTask(SetStorageGroupStatement setStorageGroupStatement) {
@Override
public ListenableFuture<ConfigTaskResult> execute() {
SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- // Construct request using statement
- TStorageGroupSchema storageGroupSchema = new TStorageGroupSchema();
- storageGroupSchema.setName(setStorageGroupStatement.getStorageGroupPath().getFullPath());
- TSetStorageGroupReq req = new TSetStorageGroupReq(storageGroupSchema);
-
- ConfigNodeClient configNodeClient = null;
- try {
- configNodeClient = new ConfigNodeClient();
- // Send request to some API server
- TSStatus tsStatus = configNodeClient.setStorageGroup(req);
- // Get response or throw exception
- if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.error(
- "Failed to execute set storage group {} in config node, status is {}.",
- setStorageGroupStatement.getStorageGroupPath(),
- tsStatus);
- future.setException(new StatementExecutionException(tsStatus));
- } else {
- future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
+ if (IoTDB.getInstance().isMppClusterMode()) {
+ // Construct request using statement
Review Comment:
Yes, it is a temporary implementation. We need to fix it in the future. Let me add a TODO mark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on code in PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#discussion_r857285287
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/config/SetStorageGroupTask.java:
##########
@@ -45,31 +48,39 @@ public SetStorageGroupTask(SetStorageGroupStatement setStorageGroupStatement) {
@Override
public ListenableFuture<ConfigTaskResult> execute() {
SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- // Construct request using statement
- TStorageGroupSchema storageGroupSchema = new TStorageGroupSchema();
- storageGroupSchema.setName(setStorageGroupStatement.getStorageGroupPath().getFullPath());
- TSetStorageGroupReq req = new TSetStorageGroupReq(storageGroupSchema);
-
- ConfigNodeClient configNodeClient = null;
- try {
- configNodeClient = new ConfigNodeClient();
- // Send request to some API server
- TSStatus tsStatus = configNodeClient.setStorageGroup(req);
- // Get response or throw exception
- if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.error(
- "Failed to execute set storage group {} in config node, status is {}.",
- setStorageGroupStatement.getStorageGroupPath(),
- tsStatus);
- future.setException(new StatementExecutionException(tsStatus));
- } else {
- future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
+ if (IoTDB.getInstance().isMppClusterMode()) {
+ // Construct request using statement
Review Comment:
Is this ```if-else``` a temporary implementation? I think this judgement should be integrated in a high level framework?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#discussion_r857289263
##########
server/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -170,6 +170,7 @@ public void joinCluster() throws StartupException {
public void active() throws StartupException {
// set the mpp mode to true
IoTDBDescriptor.getInstance().getConfig().setMppMode(true);
+ IoTDB.getInstance().setMppClusterMode();
Review Comment:
```suggestion
IoTDBDescriptor.getInstance().getConfig().setMppQueryEngineMode(true);
IoTDB.getInstance().setClusterMode();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#issuecomment-1108028586
[](https://coveralls.io/builds/48521710)
Coverage decreased (-0.003%) to 54.293% when pulling **d40cada24436b1f43a6288b45517a1d7cbe5185c on standaloneMPPWrite** into **dde44dcbe26ede26be789835d3e5f16429b9c8d3 on master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #5655: Draft of Standalone schemafetcher and PartitionFetcher
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#discussion_r857209684
##########
server/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -170,6 +170,7 @@ public void joinCluster() throws StartupException {
public void active() throws StartupException {
// set the mpp mode to true
IoTDBDescriptor.getInstance().getConfig().setMppMode(true);
+ IoTDB.getInstance().setClusterMode();
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#issuecomment-1108238796
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=5655)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL) [84 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_coverage&view=list) [54.8% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_duplicated_lines_density&view=list) [1.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #5655:
URL: https://github.com/apache/iotdb/pull/5655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#issuecomment-1108373081
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=5655)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL) [84 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_coverage&view=list) [54.5% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_duplicated_lines_density&view=list) [1.1% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #5655: Support set storage group in standalone mpp mode
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #5655:
URL: https://github.com/apache/iotdb/pull/5655#issuecomment-1108082706
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=5655)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL) [84 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=5655&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_coverage&view=list) [52.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_duplicated_lines_density&view=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=5655&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org