You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Roger Ignazio <me...@rogerignazio.com> on 2015/06/23 04:39:32 UTC
Review Request 35763: Document workaround for LIBNL_CFLAGS path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1856
https://issues.apache.org/jira/browse/MESOS-1856
Repository: mesos
Description
-------
This commit documents a workaround to MESOS-1856, telling the user that
they will need to override LIBNL_CFLAGS at build time if libnl3 was
*not* compiled and installed with `--prefix=/usr`.
Diffs
-----
docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
Diff: https://reviews.apache.org/r/35763/diff/
Testing
-------
Thanks,
Roger Ignazio
Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On June 23, 2015, 5:39 a.m., Marco Massenzio wrote:
> > Can you please add one of the committers as a reviewer?
>
> Till Toenshoff wrote:
> Did we document such requirement somewhere?
er... I was being economical with words here: I don't know if Roger is a committer himself, because if he isn't, my Ship It won't help him much.
Sorry, should have belabored the point.
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88925
-----------------------------------------------------------
On June 23, 2015, 2:39 a.m., Roger Ignazio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:39 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1856
> https://issues.apache.org/jira/browse/MESOS-1856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
>
> Diff: https://reviews.apache.org/r/35763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roger Ignazio
>
>
Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Posted by Till Toenshoff <to...@me.com>.
> On June 23, 2015, 5:39 a.m., Marco Massenzio wrote:
> > Can you please add one of the committers as a reviewer?
Did we document such requirement somewhere?
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88925
-----------------------------------------------------------
On June 23, 2015, 2:39 a.m., Roger Ignazio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:39 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1856
> https://issues.apache.org/jira/browse/MESOS-1856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
>
> Diff: https://reviews.apache.org/r/35763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roger Ignazio
>
>
Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88925
-----------------------------------------------------------
Can you please add one of the committers as a reviewer?
- Marco Massenzio
On June 23, 2015, 2:39 a.m., Roger Ignazio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:39 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1856
> https://issues.apache.org/jira/browse/MESOS-1856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
>
> Diff: https://reviews.apache.org/r/35763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roger Ignazio
>
>
Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Posted by Roger Ignazio <me...@rogerignazio.com>.
> On June 23, 2015, 2:12 p.m., Kapil Arya wrote:
> > Would this RR be still relevant after https://reviews.apache.org/r/35766/?
No, this would be superseded by 35766 and actually fixing the problem that I was doc'ing the workaround for :)
Thanks!
- Roger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88974
-----------------------------------------------------------
On June 23, 2015, 2:39 a.m., Roger Ignazio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:39 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1856
> https://issues.apache.org/jira/browse/MESOS-1856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
>
> Diff: https://reviews.apache.org/r/35763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roger Ignazio
>
>
Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88974
-----------------------------------------------------------
Would this RR be still relevant after https://reviews.apache.org/r/35766/?
- Kapil Arya
On June 22, 2015, 10:39 p.m., Roger Ignazio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 10:39 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1856
> https://issues.apache.org/jira/browse/MESOS-1856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
>
> Diff: https://reviews.apache.org/r/35763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roger Ignazio
>
>
Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88924
-----------------------------------------------------------
Ship it!
Thanks for this.
A couple of minor formatting nits.
docs/network-monitoring.md (lines 44 - 48)
<https://reviews.apache.org/r/35763/#comment141542>
Were you after the `blockquote` effect here, or was this just an artifact of copy & paste?
I would prefer that you remove the blockquote, and have the code surrounded by the ``` markers.
docs/network-monitoring.md (line 48)
<https://reviews.apache.org/r/35763/#comment141543>
please format as a markdown URL:
please see [MESOS-1856](https://issues.apache.org/jira/browse/MESOS-1856)
to be consistent with the rest of the document.
- Marco Massenzio
On June 23, 2015, 2:39 a.m., Roger Ignazio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:39 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1856
> https://issues.apache.org/jira/browse/MESOS-1856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
>
> Diff: https://reviews.apache.org/r/35763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roger Ignazio
>
>
Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763/#review88915
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35763]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 2:39 a.m., Roger Ignazio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35763/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:39 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1856
> https://issues.apache.org/jira/browse/MESOS-1856
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit documents a workaround to MESOS-1856, telling the user that
> they will need to override LIBNL_CFLAGS at build time if libnl3 was
> *not* compiled and installed with `--prefix=/usr`.
>
>
> Diffs
> -----
>
> docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
>
> Diff: https://reviews.apache.org/r/35763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roger Ignazio
>
>