[GitHub] [lucene] rmuir commented on a change in pull request #264: LUCENE-10062: Switch to numeric doc values for encoding taxonomy ordinals (instead of custom binary format)

[GitBox <gi...@apache.org>]

rmuir commented on a change in pull request #264:
URL: https://github.com/apache/lucene/pull/264#discussion_r749671027



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##########
@@ -81,4 +84,19 @@ public long cost() {
       }
     };
   }
+
+  /**
+   * Determine whether-or-not an index segment is using the older-style binary format or the newer
+   * NumericDocValues format for storing taxonomy faceting ordinals (for the specified field).
+   *
+   * @deprecated Please do not rely on this method. It is added as a temporary measure for providing
+   *     index backwards-compatibility with Lucene 9 and earlier indexes, and will be removed in
+   *     Lucene 11.
+   */
+  // TODO: Remove in Lucene 11
+  @Deprecated
+  public static boolean usesOlderBinaryOrdinals(LeafReader reader, String field) {

Review comment:
       Why this check? Can't we simply do `reader.getMetaData().getCreatedVersionMajor() < 9` or whatever, matching the exact logic at write-time in DirectoryTaxonomyWriter?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org